-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kwargs to uvicorn run #780
Conversation
Co-authored-by: Barret Schloerke <barret@posit.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (pending suggestions and changelog adjustments)
(Please squash merge when checks pass 🥳 )
@@ -59,6 +60,9 @@ Methods still under consideration in `shiny.experimental.ui`: | |||
* `card(wrapper=)`, `card_body()`, `card_image()`, `card_header()` | |||
|
|||
|
|||
### Bug fixes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this section be combined with ### Bug fixes
below?
if app_dir and app_dir not in reload_dirs: | ||
reload_dirs.append(app_dir) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
app_dir
is added to reload_dirs
above iff reload_dirs
is its default value and app_dir
is supplied.
So, we should remove this enhancement.
if app_dir and app_dir not in reload_dirs: | |
reload_dirs.append(app_dir) |
Co-authored-by: Barret Schloerke <barret@posit.co>
Coming in just a little bit late on this one, but I was just looking for a way to pass I'm exposing my app behind a reverse proxy and Is there a workaround for passing in kwargs to |
* main: (56 commits) Add actions step for nightly reporting -> Testrail (#774) Remove unused entry in manifest Bump version to 0.6.0.9000 Use latest htmltools Bump version to v0.6.0; Rearrange news to have API changes last Tweaks from testing Fix default width/height with implicit plot output (#792) Update deps (#794) Remove deprecated 'name' parameter from `Outputs` (#791) api(ui): Drop `toggle_` methods. Consolidate update accordion methods. Stronger typing for `layout_sidebar(sidebar)` and `page_sidebar(sidebar)` (#788) bug(sidebar): Revert sidebar icon back to chevron (#789) For `input_action_button`, default to having whitespace around button (#758) Remove output from template app (#775) Add output_args and suspend_display decorators (#786) Update value_box; Update to bootstrap 5.3; Update htmldeps (#772) tests: add sidebar test (#787) Seaborn plots should fill their output_plot (#785) Kwargs to uvicorn run (#780) Add width and height arguments to `@render.plot` (#783) gitgnore dist/ ...
This PR does three things:
reload-excludes
argument to shiny run, for completeness withreload-includes
uvicorn.run()
I have tested the following cases locally, but we decided that it wasn't worth adding automated tests:
reload-dir
causes the app to reload when changes occur in that dir's filesshiny run --reload --reload-includes="*.py" app.py
causes app to only reload when.py
files changeshiny run --reload --reload-includes="*.py" --reload-excludes="test.py" app.py
causes the app to reload whenapp.py
is changed, but not whentest.py
is changed.I couldn't figure out a way to pass
**kwargs
to the command line, but I still think it's a useful safety valve to include.