Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permissions error #974

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Fix permissions error #974

merged 2 commits into from
Oct 9, 2024

Conversation

dancoates
Copy link
Contributor

This would have allowed read access permissions to upsert samples

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.56%. Comparing base (f2de605) to head (184e43e).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #974   +/-   ##
=======================================
  Coverage   81.56%   81.56%           
=======================================
  Files         184      184           
  Lines       15957    15957           
=======================================
  Hits        13016    13016           
  Misses       2941     2941           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

this would have allowed read access permissions to upsert samples
@dancoates dancoates merged commit d433e62 into dev Oct 9, 2024
9 checks passed
@dancoates dancoates deleted the fix-incorrect-role branch October 9, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants