-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uplift code quality in metamist repo #957
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #957 +/- ##
==========================================
- Coverage 81.15% 81.15% -0.01%
==========================================
Files 184 184
Lines 15866 15865 -1
==========================================
- Hits 12876 12875 -1
Misses 2990 2990 ☔ View full report in Codecov by Sentry. |
Is it possible to go back to a previous analysis so we can see the reports you're addressing? (Or I guess we could cause it to analyse dev or main again…) |
That's an excellent question! I'm looking into that to figure out the best configuration for "New Code". This should allow us to compare main (or, in the case of metamist, probably dev) to the newest code that is analysed in order to compare. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work Sabrina!
I only have few questions as per my comments.
This is the beginning of the code quality uplift in metamist. This PR addresses all of the security issues, hotspots and bugs.
A separate PR will be started to reduce the tech debt in the repo.