Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uplift code quality in metamist repo #957

Merged
merged 18 commits into from
Oct 4, 2024
Merged

Conversation

violetbrina
Copy link
Contributor

@violetbrina violetbrina commented Sep 23, 2024

This is the beginning of the code quality uplift in metamist. This PR addresses all of the security issues, hotspots and bugs.
A separate PR will be started to reduce the tech debt in the repo.

@violetbrina violetbrina self-assigned this Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.15%. Comparing base (f1eba97) to head (1447e04).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #957      +/-   ##
==========================================
- Coverage   81.15%   81.15%   -0.01%     
==========================================
  Files         184      184              
  Lines       15866    15865       -1     
==========================================
- Hits        12876    12875       -1     
  Misses       2990     2990              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@violetbrina violetbrina marked this pull request as ready for review October 2, 2024 08:00
@violetbrina violetbrina requested review from jmarshall and removed request for dancoates October 3, 2024 00:50
@jmarshall
Copy link
Contributor

Is it possible to go back to a previous analysis so we can see the reports you're addressing?

(Or I guess we could cause it to analyse dev or main again…)

@violetbrina
Copy link
Contributor Author

Is it possible to go back to a previous analysis so we can see the reports you're addressing?

(Or I guess we could cause it to analyse dev or main again…)

That's an excellent question! I'm looking into that to figure out the best configuration for "New Code". This should allow us to compare main (or, in the case of metamist, probably dev) to the newest code that is analysed in order to compare.

Copy link
Contributor

@milo-hyben milo-hyben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work Sabrina!
I only have few questions as per my comments.

db/deploy/Dockerfile Outdated Show resolved Hide resolved
db/deploy/Dockerfile Outdated Show resolved Hide resolved
deploy/api/Dockerfile Outdated Show resolved Hide resolved
@violetbrina violetbrina merged commit a4450ee into dev Oct 4, 2024
9 checks passed
@violetbrina violetbrina deleted the sonarqube-quality-uplift branch October 4, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants