-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock openapi schema version for swagger UI to 3.0.2 #887
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #887 +/- ##
=======================================
Coverage 80.54% 80.54%
=======================================
Files 172 172
Lines 14641 14641
=======================================
Hits 11793 11793
Misses 2848 2848 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought swagger UI would support 3.1.0 fine? Or if it's the react flavour, should update swagger on the front-end.
The actual openapi generator should not use this function anymore.
Yeah fair point, I was tossing up whether to upgrade the swagger UI, it's a major version upgrade so could break things but I'll give it a shot |
@illusional I had a crack at updating to the new swagger ui react to support openapi def 3.1.0, but it is a bit of a rabbit hole, v5 of swagger UI requires v9 of react-redux which requires v18 of react, and upgrading to v18 of react requires updating most of our component libraries, I'm not even sure all of them will support react 18. I think it'd be good to get temporary fix out and look at upgrading react separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooft, what a rabbit hole.
* [test] Silence port errors + simplify test db construction (#886) * Attempt to silence port errors * Try not casting to an int * Maybe test not binding? * Try another approach * PR clean-up * Linting * Actually save the fiel * Reinstate findfreeport but use it better * Disable + re-disable loggers --------- Co-authored-by: Michael Franklin <illusional@users.noreply.github.com> * Upgrade deprecated pydantic methods (#888) Co-authored-by: Michael Franklin <illusional@users.noreply.github.com> * fix openapi generation for swagger ui to 3.0.2 for compatibility (#887) --------- Co-authored-by: Michael Franklin <22381693+illusional@users.noreply.github.com> Co-authored-by: Michael Franklin <illusional@users.noreply.github.com>
Not quite sure why this suddenly broke, but this seems to fix it