Custom Cohorts UI #691
Draft
Custom Cohorts UI #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-metadata into custom-cohorts
…-metadata into custom-cohorts
* add assay meta array to type * Fix rendering issues; add column customisation * add additional SG filters to GQL schema * Mod SG SQL query to filter on assay meta and sg timestamps * Add timestamp and assay field to SG model * Add assayMeta to GQL fetch * Use new optimised SG GQL query * Lint fix * Change dict value type to `Any` * Formatting * Only allow meta which is not `None` * White space trim * Add check that new sg is not archived * remove `assay_meta` in favour of nested assay object * Proceduraly add query joins as required * remove `assay_meta` in favour of nested assay object; add more filters * Options to convert/ignore specific fields in `to_sql` * Handle case when `archived` is an `int`; removed fields * Updated queries * mypy/pylint fixes * Add form inputs for remaining fields * npm audit * Remove log * Trim and remove empty values * Simplify cram/gvcf query * Remove merging - not required * Test addtional filters * test new sg filters * lint fix * Change to optional bool * mypy fix * change to `assertEqual` for better debugging * Fail fast if wrong type for `archived` * Add assay meta to detail view
…-metadata into custom-cohorts
* Also deletes redundant create_cohort endpoint
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## custom-cohorts #691 +/- ##
===============================================
Coverage 68.87% 68.87%
===============================================
Files 135 135
Lines 10476 10476
===============================================
Hits 7215 7215
Misses 3261 3261 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.