Billing Enums & Filter fixes #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illusional
approved these changes
Jan 25, 2024
milo-hyben
added a commit
that referenced
this pull request
Jan 25, 2024
Release: Billing Enums & Filter fixes (#663)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we refactor Billing models and extracted Billing enums to enum folder, the imports were not updated.
When running locally it was still working properly. A bit of annoying as linting did not report this as an issue either.
Bug only discovered when deployed to production.
The other fix is related to showing more than selected days on the chart. Issue is related to the way gcp billing records are digested and partitioned. GCP BQ table is partition by datetime it was loaded, however we need to display data based on usage_end_time, which could be off by a few days. To address it two filters needs to be used (one for usage_end_time and one for _PARTITIONTIME) when selecting from gcp table.