Update existing cohort parser with warning flag #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivbak
requested changes
Nov 19, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #616 +/- ##
==========================================
+ Coverage 70.56% 70.64% +0.07%
==========================================
Files 116 116
Lines 9316 9337 +21
==========================================
+ Hits 6574 6596 +22
+ Misses 2742 2741 -1 ☔ View full report in Codecov by Sentry. |
vivbak
requested changes
Nov 20, 2023
web/package-lock.json
Outdated
| @@ -1,12 +1,12 @@ | |||
| { | |||
| "name": "metamist", | |||
| "version": "6.3.0", | |||
There was a problem hiding this comment.
Did you intend to bump version here?
There was a problem hiding this comment.
I did not, should it be 6.3.0?
…as well as length of read_filenames. Also changed removed /venv in .gitignore file - probably best for a separate PR
Co-authored-by: Vivian Bakiris <79084890+vivbak@users.noreply.github.com>
Co-authored-by: Vivian Bakiris <79084890+vivbak@users.noreply.github.com>
…th-skip-flag' into update-existing-cohort-parser-with-skip-flag
vivbak
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #614
Added warning flag to log missing data when parsing manifests as opposed to raising a
ValueError. Also added test case that fails when aValueErroris raised and the warning flag is set toTrue.