Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: add post request for enum types #516

Merged
merged 1 commit into from
Jul 19, 2023
Merged

ADD: add post request for enum types #516

merged 1 commit into from
Jul 19, 2023

Conversation

violetbrina
Copy link
Contributor

As stated in the title. Post requests didn't exist.

@violetbrina violetbrina self-assigned this Jul 18, 2023
@violetbrina violetbrina requested review from daniaki and removed request for daniaki July 18, 2023 00:44
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: -21.73 ⚠️

Comparison is base (95fb0ba) 72.05% compared to head (9c885d2) 50.32%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #516       +/-   ##
===========================================
- Coverage   72.05%   50.32%   -21.73%     
===========================================
  Files          90       87        -3     
  Lines        7746     7287      -459     
===========================================
- Hits         5581     3667     -1914     
- Misses       2165     3620     +1455     
Impacted Files Coverage Δ
db/python/enum_tables/enums.py 80.55% <100.00%> (+0.55%) ⬆️

... and 36 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@daniaki daniaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't developed on metamist before - is it easy to add unit tests for the new route simulating a POST request?

@violetbrina
Copy link
Contributor Author

Haven't developed on metamist before - is it easy to add unit tests for the new route simulating a POST request?

I believe most of the testing done in CI is mocked anyway. There isn't really a way to test db changes without running metamist. So we usually just test the API/processing layers.

@daniaki daniaki self-requested a review July 19, 2023 02:03
Copy link
Contributor

@daniaki daniaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was meant to approve with comment, but looks good. I'll add these changes to the next release in which I will also add a fix for the broken metamist 6.1.0 package on PYPI.

@violetbrina violetbrina merged commit 1596bc9 into dev Jul 19, 2023
4 of 5 checks passed
@violetbrina violetbrina deleted the add-enum-type branch July 19, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants