Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for displaying narrow bars in interactive mode #4568

Merged
merged 8 commits into from
Feb 12, 2020
Merged

Fix for displaying narrow bars in interactive mode #4568

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4972429
fix issue 4567 - display narrow bars
archmoj Feb 10, 2020
c71ca70
should not force x1=x0 and y1=y0
archmoj Feb 11, 2020
7f3fb34
add test to ensure narrow bars are displayed similar to v1.52.1 and b…
archmoj Feb 11, 2020
c1ee8c2
add comment regarding not showing zero span bars
archmoj Feb 11, 2020
4c323bc
force x1=x0 and y1=y0 again but only with transition
archmoj Feb 11, 2020
8ebc030
add comment for transitioning empty bars
archmoj Feb 11, 2020
c83839f
revise blank bar logic
archmoj Feb 11, 2020
494775b
add transition tests for blank bars - as currently pass on master too
archmoj Feb 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 17 additions & 13 deletions src/traces/bar/plot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,25 +140,29 @@ function plot(gd, plotinfo, cdModule, traceLayer, opts, makeOnCompleteCallback)
var y0 = xy[1][0];
var y1 = xy[1][1];

var isBlank = (
x0 === x1 ||
y0 === y1 ||
!isNumeric(x0) ||
!isNumeric(x1) ||
!isNumeric(y0) ||
!isNumeric(y1)
);
// empty bars
var isBlank = (isHorizontal ? x1 - x0 : y1 - y0) === 0;

// display zeros if line.width > 0
if(isBlank && shouldDisplayZeros &&
helpers.getLineWidth(trace, di) &&
(isHorizontal ? x0 === x1 : y0 === y1)) {
if(isBlank && shouldDisplayZeros && helpers.getLineWidth(trace, di)) {
isBlank = false;
}

// skip nulls
if(!isBlank) {
isBlank = (
!isNumeric(x0) ||
!isNumeric(x1) ||
!isNumeric(y0) ||
!isNumeric(y1)
);
}

// record isBlank
di.isBlank = isBlank;

// for empty bars, ensure start and end positions are equal when having transition
if(isBlank && withTransition) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With revised logic, now there is no need for handling transitions differently.

// for blank bars, ensure start and end positions are equal - important for smooth transitions
if(isBlank) {
if(isHorizontal) {
x1 = x0;
} else {
Expand Down