Fix for displaying narrow bars in interactive mode #4568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archmoj
added
bug
etpinard
reviewed
Feb 11, 2020
|
@etpinard I am working on few more commits for this PR. |
archmoj
commented
Feb 11, 2020
etpinard
reviewed
Feb 11, 2020
|
Please note that bug reported in #4573 is also fixed in this PR. |
archmoj
commented
Feb 11, 2020
src/traces/bar/plot.js
Outdated
| di.isBlank = isBlank; | ||
|
|
||
| // for empty bars, ensure start and end positions are equal when having transition | ||
| if(isBlank && withTransition) { |
There was a problem hiding this comment.
With revised logic, now there is no need for handling transitions differently.
|
Awesome work. Thanks very much for adding those transition tests! I hope this is the last of our blank bar fixup. 💃 |
This was referenced Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4567 | Demo: before vs after
and fixes #4573 | before vs after
@plotly/plotly_js
cc: @brubbel