Update dashBio to v0.4.5 and enable asynchronous component loading #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prop should have gone under sequences > options, but was declared in defaultProps as a top-level prop. This added it to the list of top-level props for the component, even though it was not a top-level prop in the PropTypes. It therefore had no description/specified type.
package.json
Outdated
| "build:py": "node ./extract-meta src/lib/components > dash_bio/metadata.json && python get_version_info.py && python -c \"import dash; dash.development.component_loader.generate_classes('dash_bio', 'dash_bio/metadata.json')\"", | ||
| "build:py": "dash-generate-components ./src/lib/components dash_bio -p package-info.json", | ||
| "build:py_and_r": "dash-generate-components ./src/lib/components dash_bio -p package-info.json && dash-generate-components ./src/lib/components dash_bio -p package-info.json --r-prefix='dashbio' --r-depends='manhattanly'", | ||
| "build:all": "npm run build:js && npm run build:js-dev && npm run build:py_and_r", |
There was a problem hiding this comment.
Same suggestion as for DAQ
https://github.com/plotly/dash-daq/pull/79/files#r360213585
NAMESPACE
Outdated
| @@ -11,7 +11,6 @@ export(dashbioOncoPrint) | |||
| export(dashbioSequenceViewer) | |||
| export(dashbioSpeck) | |||
| export(dashbioManhattan) | |||
| export(dashbioAlignmentViewer) | |||
There was a problem hiding this comment.
Hm, I don't think this should be here -- IIRC we got rid of the AlignmentViewer component in #425
There was a problem hiding this comment.
Hmm, strange indeed. The generator should blow away the existing R and man directories before rebuilding the NAMESPACE file IIRC, not sure why that didn't happen. I'll take care of this now, thanks for catching it.
added 2 commits
December 22, 2019 18:08
|
|
shammamah-zz
approved these changes
Dec 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to update the
dashBiopackage for compatibility with Dash for R >= 0.2.0, which supports asynchronous component loading.@shammamah