Remove alignment viewer #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycaokris
approved these changes
Oct 17, 2019
| * your genes or proteins snappily thanks to the underlying WebGL architecture | ||
| * powering the component. You can quickly scroll through your long sequence | ||
| * with a slider or a heatmap overview. | ||
| * Note that the AlignmentChart only returns a chart of the sequence, while |
There was a problem hiding this comment.
This docs looks a bit confusing to me.Same as in Alignment Chart which we'll keep
dash-bio/src/lib/components/AlignmentChart.react.js
Lines 17 to 19 in 447ebbe
Does this Alignment Viewer here refers to original react component? I didn't go detailed into the difference between this two components but we could skip mentioning the one we won't be using as it'll be packed into docstring reference.
There was a problem hiding this comment.
Good catch! Will fix this ASAP :)
shammamah-zz
force-pushed
the
remove-alignmentviewer
branch
from
4aacecb
to
503382f
Compare
shammamah-zz
force-pushed
the
remove-alignmentviewer
branch
from
540984e
to
9d80694
Compare
shammamah-zz
force-pushed
the
remove-alignmentviewer
branch
from
9d80694
to
cb0e4c5
Compare
shammamah-zz
force-pushed
the
remove-alignmentviewer
branch
from
f311e53
to
842fa53
Compare
shammamah-zz
force-pushed
the
remove-alignmentviewer
branch
from
842fa53
to
0adc2b7
Compare
shammamah-zz
force-pushed
the
remove-alignmentviewer
branch
from
0adc2b7
to
42e108e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #414
About
Description of changes
Before merging