Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes, bowfin update, terrain rendering fixes #5498

Merged
merged 7 commits into from
Jan 30, 2023

Conversation

Web-eWorks
Copy link
Member

@Web-eWorks Web-eWorks commented Jan 29, 2023

Unsure how much more bugfixing will be finished before Pioneer Day, so have an early batch. I'll try to get to the other reported issues with the Scout Mission etc.

I've updated the Bowfin to have an additional 50% more equipment capacity as an interim measure before moving to volume-based equipment. This allows it to mount missiles in addition to a shield generator... 🙃 The Bowfin's class has been updated to "Light Fighter" from "Medium Fighter" (as it in no way qualifies for a medium ship).

I've also fixed an unreported bug that caused extremely poor quality terrain in elevated areas. The centroid used to calculate LOD distance to a geopatch was remaining at the "sea level" height of the planet, rather than at the average height of the terrain, causing the game to think the camera was much further from the terrain than it actually is. This makes a huge difference in visual terrain quality, but leaves the performance cost about the same as before when the player is in low-lying terrain.

Before:
image

After:
image

- Setup the equipment event listener properly on loading the game and changing ship type
- Fix loading a missing station market value from older saves (for development purposes)
- Increase capacity from 12t to 18t
- Remove merchant role
- Update price
- Autosave before launching / taking off
- Queue an event to autosave after all event handlers have been run when the player docks
- Average together the height values of all four corners of the geopatch
- Optional debug visualization of computed geopatch centroids
- Dramatically improves terrain detail at high elevations (e.g. Olympus Mons)
- Instead of storing a global version value, just annotate saves with the current version
- Migrations can be handled by checking for a specific version
- Display a tooltip indicating the autopilot is overriding the gear control
- Visually disable the button
@Bodasey
Copy link

Bodasey commented Jan 29, 2023

Maybe you can also easily fix #4123 this way?

@Web-eWorks
Copy link
Member Author

That in fact should already be fixed - autosave on takeoff is made before the ship is actually undocked (so if you forget something, you can quickload and buy/sell your commodities).

@Bodasey
Copy link

Bodasey commented Jan 29, 2023

#4123 fix confirmed

#5470 fix confirmed

#5479 very probably fixed

@Bodasey
Copy link

Bodasey commented Jan 30, 2023

While flying from Earth to Jupiter:

Warning: Caught error in Lua UI code:
[T] pigui/modules/info-view/03-econ-trade.lua:71: Cannot call tableSetupColumn() outside of a beginTable() / endTable() pair

Hang with a long LUA error report, said it was written to output.txt, but there's nothing of this.

@Web-eWorks
Copy link
Member Author

Hang with a long LUA error report, said it was written to output.txt, but there's nothing of this.

Without the output.txt I cannot address this issue. If it occurs again, please get the error info from output.txt and make a new issue with it (as this is unrelated to this PR).

@Web-eWorks Web-eWorks merged commit 0cbd387 into pioneerspacesim:master Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment