Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure autosave before the onGameEnd event fires #5456

Merged
merged 2 commits into from
Dec 25, 2022
Merged

Ensure autosave before the onGameEnd event fires #5456

merged 2 commits into from
Dec 25, 2022

Commits on Dec 25, 2022

  1. Ensure autosave before the onGameEnd event fires 

    Since the autosave at the end of the game was triggered by the onGameEnd
event, it was randomly queued among other subscribers to this event.
This resulted in (at least) an accidental loss of all TradeShips module
data during autosave when exiting the game.

Among other options, I chose to create a separate
'onAutoSaveBeforeGameEnds' event, as this seems to me the most
straightforward and clear.

Fixes pioneerspacesim#5427
    @Gliese852
    Gliese852 committed Dec 25, 2022
    Configuration menu
    Copy the full SHA
    0660f5f View commit details
    Browse the repository at this point in the history

  2. Make a more relevant comment in TradeShips

    @Gliese852
    Gliese852 committed Dec 25, 2022
    Configuration menu
    Copy the full SHA
    b507356 View commit details
    Browse the repository at this point in the history