Ensure autosave before the onGameEnd event fires #5456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the autosave at the end of the game was triggered by the onGameEnd event, it was randomly queued among other subscribers to this event. This resulted in (at least) an accidental loss of all TradeShips module data during autosave when exiting the game. Among other options, I chose to create a separate 'onAutoSaveBeforeGameEnds' event, as this seems to me the most straightforward and clear. Fixes pioneerspacesim#5427
Can you please also add documentation string for it in data/libs/Event.lua, where we have the other events documented |
|
Tested, also fixes #5305 ! |
Web-eWorks
approved these changes
Dec 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the autosave at the end of the game was triggered by the
onGameEndevent, it was randomly queued among other subscribers to this event. This resulted in (at least) an accidental loss of all TradeShips module data during autosave when exiting the game.Among other options, I chose to create a separate
onAutoSaveBeforeGameEndsevent, as this seems to me the most straightforward and clear.Fixes #5427