Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Typehint the Stream class and fix deprecated interface HttpClient #70

Open
wants to merge 2 commits into
base: 2.x
Choose a base branch
from

Conversation

tarekdj
Copy link

@tarekdj tarekdj commented Oct 23, 2023

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
Documentation
License MIT

What's in this PR?

  • Fix the type hinting of Stream class in order to make it compatible with StreamInterface
  • Replace depreacted interface HttpClient

Why?

Fix the compatibility of Stream class with the StreamInterface

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
  • Documentation pull request created (if not simply a bugfix)

To Do

  • Update CHANGELOG.md

@dbu
Copy link
Contributor

dbu commented Jan 6, 2024

we could switch this client to be a PSR-18 client. but that would mean somebody would need to commit to maintain this client. there are a bunch of http clients around: symfony, guzzle, buzz, the php-http/curl-client and some others.

is there value in keeping the socket client alive?

@dbu
Copy link
Contributor

dbu commented Jan 6, 2024

if we decide to keep this maintained, we should adjust the socket-client.rst page in the documentation, reverting php-http/documentation#310 (comment) and maybe add more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants