Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦 Explicitly declare dependency to psr/http-message #4

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

andrew-demb
Copy link

Restrict the installed version to v1 because the package compatible only with v1

Without declared dependency for now composer installs psr/http-message and it leads to the fatal error:

PHP Fatal error: Declaration of Http\Client\Socket\Stream::close() must be compatible with Psr\Http\Message\StreamInterface::close(): void in /.../vendor/code-tool/socket-client/src/Stream.php on line 78

To fix compatibility with v2 it's needed to break BC for extended classes from Stream. See PR in upstream for example changes php-http#70

Restrict the installed version to `v1` because the package compatible only with `v1`
@asp24 asp24 merged commit 125e018 into code-tool:master Jan 24, 2024
@andrew-demb andrew-demb deleted the patch-1 branch January 24, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants