Type hasfreespace condition

src/Phing/Task/System/Condition/HasFreeSpaceCondition.php

@@ -22,6 +22,7 @@
 
 use Phing\Exception\BuildException;
 use Phing\Util\SizeHelper;
+use Throwable;
 
 /**
  * Condition returns true if selected partition has the requested space, false otherwise.
@@ -44,38 +45,45 @@ class HasFreeSpaceCondition implements Condition
      * {@inheritdoc}
      *
      * @throws BuildException
-     *
-     * @return bool
      */
-    public function evaluate()
+    public function evaluate(): bool
     {
         $this->validate();
 
-        $free = disk_free_space($this->partition);
+        try {
+            $free = disk_free_space($this->partition);
+        } catch (Throwable $throwable) {
+            // Only when "display errors" is enabled.
+            throw new BuildException($throwable->getMessage());
+        }
+
+        if (false === $free) {
+            throw new BuildException('Error while retrieving free space.');
+        }
 
         return $free >= SizeHelper::fromHumanToBytes($this->needed);
     }
 
     /**
      * Set the partition/device to check.
      */
-    public function setPartition(string $partition)
+    public function setPartition(string $partition): void
     {
         $this->partition = $partition;
     }
 
     /**
      * Set the amount of free space required.
      */
-    public function setNeeded(string $needed)
+    public function setNeeded(string $needed): void
     {
         $this->needed = $needed;
     }
 
     /**
      * @throws BuildException
      */
-    private function validate()
+    private function validate(): void
     {
         if (null == $this->partition) {
             throw new BuildException('Please set the partition attribute.');

tests/Phing/Task/System/Condition/HasFreeSpaceConditionTest.php

@@ -0,0 +1,40 @@
+<?php
+
+namespace Phing\Task\System\Condition;
+
+use Phing\Test\Support\BuildFileTest;
+
+class HasFreeSpaceConditionTest extends BuildFileTest
+{
+    public function setUp(): void
+    {
+        $this->configureProject(PHING_TEST_BASE . '/etc/tasks/system/HasFreeSpaceConditionTest.xml');
+    }
+
+    public function testPartitionNotSet()
+    {
+        $this->expectBuildExceptionContaining(__FUNCTION__, __FUNCTION__, 'Please set the partition attribute.');
+    }
+
+    public function testNeededNotSet()
+    {
+        $this->expectBuildExceptionContaining(__FUNCTION__, __FUNCTION__, 'Please set the needed attribute.');
+    }
+
+    public function testInvalidPartition()
+    {
+        $this->expectBuildExceptionContaining(__FUNCTION__, __FUNCTION__, 'disk_free_space(): No such file or directory');
+    }
+
+    public function testEnoughSpace()
+    {
+        $this->executeTarget(__FUNCTION__);
+        $this->assertInLogs('HasFreeSpaceConditionTest: Enough space in disk.');
+    }
+
+    public function testNotEnoughSpace()
+    {
+        $this->executeTarget(__FUNCTION__);
+        $this->assertInLogs('HasFreeSpaceConditionTest: Not enough space in disk.');
+    }
+}

tests/etc/tasks/system/HasFreeSpaceConditionTest.xml

@@ -0,0 +1,53 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+
+<project name="HasFreeSpaceConditionTest" default="testPartitionNotSet">
+
+    <if>
+        <os family="windows"/>
+        <then>
+            <property name="my.partition" value="C:"/>
+        </then>
+        <else>
+            <property name="my.partition" value="/"/>
+        </else>
+    </if>
+
+    <target name="testPartitionNotSet">
+        <if>
+            <hasfreespace/>
+        </if>
+    </target>
+
+    <target name="testNeededNotSet">
+        <if>
+            <hasfreespace partition="${my.partition}"/>
+        </if>
+    </target>
+
+    <target name="testInvalidPartition">
+        <if>
+            <hasfreespace partition="foo" needed="1M"/>
+        </if>
+    </target>
+
+    <target name="testEnoughSpace">
+        <if>
+            <hasfreespace partition="${my.partition}" needed="1M"/>
+            <then>
+                <echo>HasFreeSpaceConditionTest: Enough space in disk.</echo>
+            </then>
+        </if>
+    </target>
+
+    <target name="testNotEnoughSpace">
+        <if>
+            <not>
+                <hasfreespace partition="${my.partition}" needed="900TiB"/>
+            </not>
+            <then>
+                <echo>HasFreeSpaceConditionTest: Not enough space in disk.</echo>
+            </then>
+        </if>
+    </target>
+
+</project>