Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type hasfreespace condition #1653

Merged
merged 40 commits into from
Jan 19, 2022
Merged

Type hasfreespace condition #1653

merged 40 commits into from
Jan 19, 2022

Conversation

jawira
Copy link
Contributor

@jawira jawira commented Dec 16, 2021

I added some typing and tests for HasFreeSpace condition

jawira and others added 30 commits February 11, 2019 14:27
@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #1653 (2bf5e64) into main (58ef3ef) will increase coverage by 0.09%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1653      +/-   ##
============================================
+ Coverage     58.12%   58.22%   +0.09%     
- Complexity     7007     7009       +2     
============================================
  Files           356      356              
  Lines         16907    16911       +4     
============================================
+ Hits           9828     9847      +19     
+ Misses         7079     7064      -15     
Impacted Files Coverage Δ
...ng/Task/System/Condition/HasFreeSpaceCondition.php 94.11% <88.88%> (+94.11%) ⬆️
src/Phing/Task/System/Condition/ConditionBase.php 84.09% <0.00%> (+3.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58ef3ef...2bf5e64. Read the comment docs.

@jawira jawira marked this pull request as draft December 27, 2021 11:39
@mrook
Copy link
Member

mrook commented Jan 18, 2022

@jawira can you update/finalize this one?

@jawira jawira marked this pull request as ready for review January 18, 2022 22:02
@jawira
Copy link
Contributor Author

jawira commented Jan 18, 2022

@mrook Done. The idea behind this is MR is to throw an exception if path is invalid.

@mrook mrook merged commit be0a65b into phingofficial:main Jan 19, 2022
@jawira jawira deleted the has-free-space branch January 19, 2022 16:20
@mrook mrook added this to the 3.0.0-RC4 milestone Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants