Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHPUnitReportTask] Fixed windows detection #1429

Merged
merged 2 commits into from
Nov 11, 2020
Merged

[PHPUnitReportTask] Fixed windows detection #1429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32a587a
Update PHPUnitReportTask.php
siad007 Nov 10, 2020
5600727
Updated deps
siad007 Nov 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion classes/phing/tasks/ext/phpunit/PHPUnitReportTask.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ protected function transform(DOMDocument $document)
$toDir = (string) $this->toDir;

// urlencode() the path if we're on Windows
if (FileSystem::getFileSystem()->getSeparator() === '\\') {
if (OsCondition::isOS(OsCondition::FAMILY_WINDOWS)) {
$toDir = urlencode($toDir);
}

Expand Down
88 changes: 42 additions & 46 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 13 additions & 13 deletions custom.task.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,29 +17,29 @@
#

apigen=Phing\Tasks\Ext\ApiGenTask
coverage-setup=Phing\Tasks\Ext\Coverage\CoverageSetupTask
coverage-merger=Phing\Tasks\Ext\Coverage\CoverageMergerTask
coverage-report=Phing\Tasks\Ext\Coverage\CoverageReportTask
coverage-threshold=Phing\Tasks\Ext\Coverage\CoverageThresholdTask
ftpdeploy=Phing\Tasks\Ext\FtpDeployTask
ioncubeencoder=Phing\Tasks\Ext\IoncubeEncoderTask
ioncubelicense=Phing\Tasks\Ext\IoncubeLicenseTask
jshint=Phing\Tasks\Ext\JsHintTask
jsmin=Phing\Tasks\Ext\JsMinTask
liquibase-changelog=Phing\Tasks\Ext\LiquibaseChangeLogTask
liquibase-dbdoc=Phing\Tasks\Ext\LiquibaseDbDocTask
liquibase-diff=Phing\Tasks\Ext\LiquibaseDiffTask
liquibase-rollback=Phing\Tasks\Ext\LiquibaseRollbackTask
liquibase-tag=Phing\Tasks\Ext\LiquibaseTagTask
liquibase-update=Phing\Tasks\Ext\LiquibaseUpdateTask
liquibase=Phing\Tasks\Ext\LiquibaseTask
coverage-setup=Phing\Tasks\Ext\Coverage\CoverageSetupTask
coverage-merger=Phing\Tasks\Ext\Coverage\CoverageMergerTask
coverage-report=Phing\Tasks\Ext\Coverage\CoverageReportTask
coverage-threshold=Phing\Tasks\Ext\Coverage\CoverageThresholdTask
ftpdeploy=Phing\Tasks\Ext\FtpDeployTask
phkpackage=Phing\Tasks\Ext\PhkPackageTask
ioncubeencoder=Phing\Tasks\Ext\IoncubeEncoderTask
ioncubelicense=Phing\Tasks\Ext\IoncubeLicenseTask
phpdoc=Phing\Tasks\Ext\PhpDocumentor2Task
phpdoc2=Phing\Tasks\Ext\PhpDocumentor2Task
smarty=Phing\Tasks\Ext\SmartyTask
zendcodeanalyzer=Phing\Tasks\Ext\ZendCodeAnalyzerTask
analyze=Phing\Tasks\Ext\ZendCodeAnalyzerTask
ssh=Phing\Tasks\Ext\SshTask
scp=Phing\Tasks\Ext\ScpTask
phpdoc=Phing\Tasks\Ext\PhpDocumentor2Task
phpdoc2=Phing\Tasks\Ext\PhpDocumentor2Task
jsmin=Phing\Tasks\Ext\JsMinTask
jshint=Phing\Tasks\Ext\JsHintTask
zendcodeanalyzer=Phing\Tasks\Ext\ZendCodeAnalyzerTask
analyze=Phing\Tasks\Ext\ZendCodeAnalyzerTask
zsdtvalidate=Phing\Tasks\Ext\ZsdtValidateTask
zsdtpack=Phing\Tasks\Ext\ZsdtPackTask