Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHPUnitReportTask] Fixed windows detection #1429

Merged
merged 2 commits into from
Nov 11, 2020
Merged

[PHPUnitReportTask] Fixed windows detection #1429

merged 2 commits into from
Nov 11, 2020

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Nov 10, 2020

@BlairCooper would you mind to check this PR? It is related to your efile:// stream wrapper issue in the PHPUnitReportTask.

@siad007 siad007 added this to the 3.0.0-rc1 milestone Nov 10, 2020
@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #1429 (5600727) into master (6590ad5) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1429   +/-   ##
=========================================
  Coverage     54.27%   54.27%           
  Complexity     9119     9119           
=========================================
  Files           467      467           
  Lines         22153    22153           
=========================================
  Hits          12024    12024           
  Misses        10129    10129           
Impacted Files Coverage Δ Complexity Δ
...sses/phing/tasks/ext/phpunit/PHPUnitReportTask.php 0.00% <0.00%> (ø) 33.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6590ad5...5600727. Read the comment docs.

Copy link
Contributor

@BlairCooper BlairCooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the change is appropriate as it explicitly references Windows instead of an implied reference though I'm not sure if that was the problem I was seeing. Part of my problem was that the coverage.db isn't getting populated.

@siad007
Copy link
Member Author

siad007 commented Nov 11, 2020

I think the change is appropriate as it explicitly references Windows instead of an implied reference though I'm not sure if that was the problem I was seeing. Part of my problem was that the coverage.db isn't getting populated.

@BlairCooper Is it somehow possible for you to test your build with this changes?

@siad007 siad007 merged commit 0c03f01 into master Nov 11, 2020
@siad007
Copy link
Member Author

siad007 commented Nov 11, 2020

@BlairCooper I decided to merge this small changes and close this ticket. Feel free to reopen or create a new ticket when future issues occure here.

@siad007 siad007 deleted the siad007-patch-3 branch November 11, 2020 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants