Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opened IoncubeEncoderTask to all php versions #1005

Merged
merged 3 commits into from
Dec 9, 2018
Merged

Opened IoncubeEncoderTask to all php versions #1005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a676512
Opened IoncubeEncoderTask to all versions
MaximilianKresse Dec 6, 2018
6f1ce9b
Update optionaltasks.xml
MaximilianKresse Dec 6, 2018
582a09d
Merge branch 'master' into patch-3
siad007 Dec 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions classes/phing/tasks/ext/ioncube/IoncubeEncoderTask.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,12 +574,7 @@ public function main()
{
$arguments = $this->constructArguments();

if (in_array($this->phpVersion, [5, 53, 54, 55, 56, 71])) {
$encoderName = $this->encoderName . $this->phpVersion;
} else {
$encoderName = $this->encoderName;
}
$encoder = new PhingFile($this->ioncubePath, $encoderName);
$encoder = new PhingFile($this->ioncubePath, $this->encoderName . $this->phpVersion);
siad007 marked this conversation as resolved.
Show resolved Hide resolved

$this->log("Running ionCube Encoder...");

Expand Down
4 changes: 2 additions & 2 deletions docs/guide/en/source/appendixes/optionaltasks.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5001,8 +5001,8 @@ Note that you can omit both startpoint and track attributes in this case
</row>
<row>
<entry><literal>phpversion</literal></entry>
<entry><literal role="type">Integer</literal></entry>
<entry>The PHP version to use</entry>
<entry><literal role="type">String</literal></entry>
<entry>Defines which php encoder version will be used (suffix of the encoder file)</entry>
<entry>5</entry>
<entry>No</entry>
</row>
Expand Down