Opened IoncubeEncoderTask to all php versions #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed fallback if unknown encoder version is given because it could cause unexpected behaviour
MaximilianKresse
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1005 +/- ##
============================================
+ Coverage 45.18% 45.19% +<.01%
+ Complexity 9949 9948 -1
============================================
Files 502 502
Lines 24105 24102 -3
============================================
Hits 10893 10893
+ Misses 13212 13209 -3
Continue to review full report at Codecov.
|
siad007
reviewed
Dec 9, 2018
mrook
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every new php version we come to the problem that the phing task have to manually changed to support the new version. See #335 #485 #130
To solve this once and for all the phpversion should be removed and allow everything given. So we can also finally use this x64 versions of ioncube encoder without renaming the encoder files.