Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#65 adds super initialize to classes. #93

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

lopezca
Copy link
Contributor

@lopezca lopezca commented Jun 26, 2023

Fixes #65

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #93 (3411640) into master (350d8b3) will increase coverage by 0.00%.
The diff coverage is 90.00%.

@@           Coverage Diff           @@
##           master      #93   +/-   ##
=======================================
  Coverage   77.50%   77.51%           
=======================================
  Files         467      467           
  Lines       49521    49529    +8     
=======================================
+ Hits        38382    38390    +8     
  Misses      11139    11139           
Impacted Files Coverage Δ
src/Glorp/GlorpPreparedStatement.class.st 0.00% <0.00%> (ø)
src/Glorp/CacheManager.class.st 89.15% <100.00%> (+0.13%) ⬆️
src/Glorp/DatabaseCommand.class.st 75.38% <100.00%> (+0.19%) ⬆️
src/Glorp/DatabaseConverter.class.st 61.90% <100.00%> (+1.90%) ⬆️
src/Glorp/DatabaseIndex.class.st 72.50% <100.00%> (+0.34%) ⬆️
src/Glorp/ForeignKeyConstraint.class.st 67.24% <100.00%> (+0.14%) ⬆️
src/Glorp/GlorpSession.class.st 70.64% <100.00%> (+0.06%) ⬆️

Copy link
Contributor

@astares astares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks!

@astares astares merged commit 0bc8826 into pharo-rdbms:master Jun 26, 2023
30 checks passed
@lopezca lopezca deleted the small-cleanups branch June 27, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup: CacheManager>>#initialize should send super initialize
2 participants