Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: CacheManager>>#initialize should send super initialize #65

Closed
astares opened this issue Jun 1, 2023 · 1 comment · Fixed by #93
Closed

Cleanup: CacheManager>>#initialize should send super initialize #65

astares opened this issue Jun 1, 2023 · 1 comment · Fixed by #93

Comments

@astares
Copy link
Contributor

astares commented Jun 1, 2023

The method CacheManager>>#initialize should start with a super initialize,
@astares
Copy link
Contributor Author

astares commented Jun 1, 2023 •
edited
Loading

Same in

  • DatabaseCommand>>#initialize
  • GlorpSession>>#initialize
  • DatabaseConverter>>#initialize
  • DatabaseIndex>>#initialize
  • GlorpPreparedStatement>>#initialize
    and
  • ForeignKeyConstraint>>#initialize

lopezca added a commit to lopezca/glorp that referenced this issue Jun 26, 2023
@lopezca
pharo-rdbms#65 adds super initialize to classes.
3411640
@lopezca lopezca mentioned this issue Jun 26, 2023
Merged
astares added a commit that referenced this issue Jun 26, 2023
@astares
Merge pull request #93 from lopezca/small-cleanups
0bc8826 
#65 adds super initialize to classes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#65 adds super initialize to classes. lopezca/glorp
1 participant
@astares