Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error: Invalid device label #1506

Closed
adima73 opened this issue Apr 10, 2020 · 7 comments
Closed

Error: Invalid device label #1506

adima73 opened this issue Apr 10, 2020 · 7 comments
Assignees
@pbatard
Labels
cant_replicate

Comments

@adima73
Copy link

adima73 commented Apr 10, 2020

When creating a boot disk WITHOUT LABEL, for example "Freedos", Rufus sets the volume label, for example "New 7.8GB volume label (set by the size of the disk)" after process which it gives an "Error: Invalid device label" and you have to change it manually. If I remember correctly, on FAT and FAT32 the volume label cannot contain the following characters (this restriction does not apply to NTFS):
*? / \ | . ,; : + = [] <> "
@pbatard
Copy link
Owner

pbatard commented Apr 10, 2020 •
edited
Loading

We do sanitize labels (see here), so your assumption that we simply forgot to filter unallowed characters is wrong.

Especially I am not seeing any issue with a FreeDOS drive labelled New 7.8GB volume label (set by the size of the disk), be it when creating the drive in Rufus or when booting FreeDOS.

Please provide a log, because I have no idea where you are getting your error from.

You are not above following the checklist, even if you (erroneously) think you know what the problem is. At the very least, please indicate where exactly you are seeing that Error: Invalid device label being generated, and what the precise label you tried to use was, as I'm afraid your report is currently way to vague and impossible to replicate, for me to be able to do anything about it (which is also the reason why I didn't bother to reply to your earlier e-mail btw).

@pbatard pbatard self-assigned this Apr 10, 2020
@adima73
Copy link
Author

adima73 commented Apr 10, 2020

I tried formatting with a volume label of 7.8 in Windows when I entered 7.8 , I received the warning "Invalid input: volume names FAT and FAT32 the volume label cannot contain the following characters: *? / \ | . ,; : + = [] <> "

The reason is found: In the Russian version of the interface, rufus tries to write the label 7.8 on that - it is indicated in the "Volume label" field and we get an error, but in the English version of the interface the program displays the label in the "Volume label" 7.8 field and writes label 7_8 and the error is not generated.

@pbatard
Copy link
Owner

pbatard commented Apr 10, 2020

I still don't see it even when switching to Russian

Please provide your full log (you can access it with Ctrl-L or by clicking the last small icon left of 'START'), and tell me exactly what you enter in the 'Volume label' field.

@adima73
Copy link
Author

adima73 commented Apr 10, 2020 •
edited by pbatard
Loading 

Rufus x86 v3.9.1624 (Portable)
Windows version: Windows 10 64-bit (Build 18363.752)
Syslinux versions: 4.07/2013-07-25, 6.04/pre1
Grub versions: 0.4.6a, 2.04
System locale ID: 0x0419 (ru-RU)
Will use default UI locale 0x0419
SetLGP: Successfully set NoDriveTypeAutorun policy to 0x0000009E
Localization set to 'ru-RU'
Found USB 2.0 device 'Generic Flash Disk USB Device' (058F:6387)
1 device found
Disk type: Removable, Disk size: 7.8Гб, Sector size: 512 bytes
Cylinders: 945, Tracks per cylinder: 255, Sectors per track: 63
Partition type: MBR, NB Partitions: 1
Disk ID: 0x0152E022
Drive has a Zeroed Master Boot Record
Partition 1:
  Type: FAT32 LBA (0x0c)
  Size: 7.2 GB (7779385344 bytes)
  Start Sector: 2048, Boot: Yes
Found USB 2.0 device 'Generic Flash Disk USB Device' (058F:6387)
1 device found
Disk type: Removable, Disk size: 7.8Гб, Sector size: 512 bytes
Cylinders: 945, Tracks per cylinder: 255, Sectors per track: 63
Partition type: MBR, NB Partitions: 1
Disk ID: 0x0152E022
Drive has a Zeroed Master Boot Record
Partition 1:
  Type: FAT32 LBA (0x0c)
  Size: 7.2 GB (7779385344 bytes)
  Start Sector: 2048, Boot: Yes
Found USB 2.0 device 'Generic Flash Disk USB Device' (058F:6387)
1 device found
Disk type: Removable, Disk size: 7.8Гб, Sector size: 512 bytes
Cylinders: 945, Tracks per cylinder: 255, Sectors per track: 63
Partition type: MBR, NB Partitions: 1
Disk ID: 0x0152E022
Drive has a Zeroed Master Boot Record
Partition 1:
  Type: FAT32 LBA (0x0c)
  Size: 7.2 GB (7779385344 bytes)
  Start Sector: 2048, Boot: Yes
1 device found
Disk type: Removable, Disk size: 7.8Гб, Sector size: 512 bytes
Cylinders: 945, Tracks per cylinder: 255, Sectors per track: 63
Partition type: MBR, NB Partitions: 1
Disk ID: 0x0152E022
Drive has a Zeroed Master Boot Record
Partition 1:
  Type: FAT32 LBA (0x0c)
  Size: 7.2 GB (7779385344 bytes)
  Start Sector: 2048, Boot: Yes

Format operation started
Requesting disk access...
Will use 'E:' as volume mountpoint
Deleting partitions...
Deleting ALL partition(s) from disk '\\?\PhysicalDrive1':
● Partition 1 (offset: 1048576, size: 7.2 Гб)
Opened \\.\PhysicalDrive1 for exclusive write access
Analyzing existing boot records...
Drive has a Zeroed Master Boot Record
Clearing MBR/PBR/GPT structures...
Erasing 128 sectors
Deleting partitions...
Partitioning (MBR)...
● Creating Main Data Partition (offset: 1048576, size: 7.2 GB)
Closing existing volume...
Waiting for logical drive to reappear...
FAT label is mostly underscores. Using '7.8Гб' label instead.
Formatting (FAT32)...
Using cluster size: 4096 bytes
Quick format was selected
Creating file system...
Bad label
[0x00000032] Такой запрос не поддерживается. - Retrying...
[0x00000032] Такой запрос не поддерживается. - Retrying...
[0x00000032] Такой запрос не поддерживается. - Retrying...
[0x00000032] Такой запрос не поддерживается. - Retrying...
Format error: The volume label is invalid.
Re-mounted volume as E: after error

Found USB 2.0 device 'Generic Flash Disk USB Device' (058F:6387)
1 device found
No volume information for drive 0x81
Disk type: Removable, Disk size: 7.8Гб, Sector size: 512 bytes
Cylinders: 945, Tracks per cylinder: 255, Sectors per track: 63
Partition type: MBR, NB Partitions: 1
Disk ID: 0x01798236
Drive has a Zeroed Master Boot Record
Partition 1:
  Type: FAT32 LBA (0x0c)
  Size: 7.2 GB (7779385344 bytes)
  Start Sector: 2048, Boot: Yes
Closed Windows format prompt
Found USB 2.0 device 'Generic Flash Disk USB Device' (058F:6387)
1 device found
No volume information for drive 0x81
Disk type: Removable, Disk size: 7.8Гб, Sector size: 512 bytes
Cylinders: 945, Tracks per cylinder: 255, Sectors per track: 63
Partition type: MBR, NB Partitions: 1
Disk ID: 0x01798236
Drive has a Zeroed Master Boot Record
Partition 1:
  Type: FAT32 LBA (0x0c)
  Size: 7.2 GB (7779385344 bytes)
  Start Sector: 2048, Boot: Yes

@pbatard
Copy link
Owner

pbatard commented Apr 10, 2020

Thanks. Now I'm starting to see a bit clearer at last. I wish you had provided your log from the start, because the one important line is this:

FAT label is mostly underscores. Using '7.8Гб' label instead.

I need to look into it some more, but at least now I have a starting point to try to understand the issue.

@pbatard
Copy link
Owner

pbatard commented Apr 10, 2020

This will be fixed in the next release.

dyeske pushed a commit to dyeske/rufus that referenced this issue Jul 3, 2020
@pbatard @dyeske
[core] fix potential invalid label for non western locales
721c401 
* If a converted label contains mostly underscore, the proposed
  label is used for FAT32 instead. However this label still has
  the KB/MB/GB symbols localized so it may be invalid.
* Ensure that we use a non-localized version of the size when
  using such a label.
* Closes pbatard#1506.
* Also fix a VS2019 static analysis warning in net.c.
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pbatard pbatard

Labels
cant_replicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pbatard @adima73