Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm64: add support for libusb0 on arm64 #314

Closed
wants to merge 4 commits into from

Conversation

dontech
Copy link
Contributor

@dontech dontech commented Feb 18, 2024

A few patches to add more ARM64 support for libwdi

@dontech dontech closed this Feb 18, 2024
@dontech dontech reopened this Feb 18, 2024
@dontech
Copy link
Contributor Author

dontech commented Feb 18, 2024

Added the problem seen in: #301

@dontech
Copy link
Contributor Author

dontech commented Feb 18, 2024

Fixed the missing files in the workflow

@pbatard
Copy link
Owner

pbatard commented Feb 21, 2024

Thanks for this PR. The one problem I have with it is that I don't think I want to apply the last patch because it references a non-official release of libusb-win32. Libwdi and especially Zadig provides links to the SourceForge directory, and the latest official release there is still 1.2.7.3 so as long as it remains that way, I don't see myself embedding files (and a version of libusb-win32) that people who click on the libusb-win32 link in Zadig will not find under official releases.

@mcuee, do you guys plan to publish an official release of libusb-win32 with the ARM64 drivers at some stage?

@mcuee
Copy link
Contributor

mcuee commented Feb 21, 2024

@pbatard

Yes, hopefully we do not have new issues and soon 1.4.0 official release will come out.

It is okay for you to wait for 1.4.0 official release.

@pbatard
Copy link
Owner

pbatard commented Feb 21, 2024

Okay, then I'll wait for the 1.4.0 release then (which I don't mind, as I'm afraid this patchset is still low priority for me, but I'll try to get through this over the next couple of months).

@dontech
Copy link
Contributor Author

dontech commented Feb 21, 2024

OK i will release 1.4.0 now

@dontech
Copy link
Contributor Author

dontech commented Feb 22, 2024

@dontech
Copy link
Contributor Author

dontech commented Feb 22, 2024

Please tell me if anything else is blocking this PR

@mcuee
Copy link
Contributor

mcuee commented Feb 22, 2024

@dontech

I think @pbatard prefer to use Sourceforge download link. Please upload 1.4.0.0 there as well. Thanks.
https://sourceforge.net/projects/libusb-win32/files/libusb-win32-releases/

@dontech
Copy link
Contributor Author

dontech commented Feb 23, 2024

We have not uploaded there in a while, and I would prefer not to, as it would signal that SF site was still alive, which it is not. And why would libwdi prefer to download form SourceForge when it itself is hosted on github?

Update to 1.4.0.0 libusb0
@mcuee
Copy link
Contributor

mcuee commented Feb 23, 2024

Yes I also prefer to use github.

@pbatard Is that okay for you? Thanks.

@dontech
Copy link
Contributor Author

dontech commented Feb 23, 2024

I updated the libusb0 reference to 1.4.0.0 so we should be GTG! 👍

@pbatard
Copy link
Owner

pbatard commented Feb 23, 2024

So what is the official URL for libusb-win32 now?

If it has changed, then I will have to update all the URLs that are referenced in libwdi and Zadig before I can produce a new release.

@dontech
Copy link
Contributor Author

dontech commented Feb 23, 2024

So what is the official URL for libusb-win32 now?

That is probably a bit up in the air. @mcuee started the move to github, and I sort of just followed. Sourceforge has not been updated for a long time, but still exists and refers forward to github, so I do not think there is any harm in referencing both for now.

But the download site is now github AKAIK.

@pbatard
Copy link
Owner

pbatard commented Feb 23, 2024

Could you please sort out a single site then?

From the standpoint of users having to juggle multiple sites is not ideal. So, if you want to ditch SourceForge, and are clearly planning to leave a download section there with obsolete releases (which is going to be super confusing for users if you state that SourceForge is more or less still active), could you please make one GitHub URL the new official one?

Oh and please update SF then to state that it's obsolete and point to the new repo.

@mcuee
Copy link
Contributor

mcuee commented Feb 23, 2024

Okay, we will put a note telling the user to go to github.

@mcuee
Copy link
Contributor

mcuee commented Feb 23, 2024

@pbatard
Copy link
Owner

pbatard commented Feb 23, 2024

Appreciated, thanks.

@mcuee
Copy link
Contributor

mcuee commented May 1, 2024

@pbatard
libusb-win32 1.4.0 has been released for a while, is it possible that you apply this PR? Thanks.

@pbatard
Copy link
Owner

pbatard commented May 1, 2024

I'm not sure I'll have much time for libwdi before the Rufus 4.5 release, which is still about 3 weeks away, but I'll see what I can do.

@pbatard
Copy link
Owner

pbatard commented Jun 13, 2024

Applied. Sorry it took so long...

@pbatard pbatard closed this in 63dbca8 Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants