Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libwdi Zadig and libusb-win32 1.3.0.x release #301

Closed
mcuee opened this issue Oct 10, 2023 · 14 comments
Closed

libwdi Zadig and libusb-win32 1.3.0.x release #301

mcuee opened this issue Oct 10, 2023 · 14 comments

Comments

@mcuee
Copy link
Contributor

mcuee commented Oct 10, 2023

Somehow libwdi/Zadig can not detect the proper version number of libusb-win32 1.3.0.0 snapshot release. Strage.

There are no issues with libusb-win32 1.2.7.3 or 1.2.7.4.

Screenshot 2023-10-10 185842

@mcuee
Copy link
Contributor Author

mcuee commented Oct 10, 2023

This is invalid. I believe it has been fixed in libusb-win32 git HEAD.
mcuee/libusb-win32@241e2ef

@mcuee mcuee closed this as completed Oct 10, 2023
@mcuee
Copy link
Contributor Author

mcuee commented Oct 10, 2023

But it is still a bit strange how libwdi detect the libusb-win32 version. I thought it uses libusb0.sys and not libusb0.dll.

@mcuee mcuee reopened this Nov 8, 2023
@mcuee mcuee changed the title libwdi Zadig and libusb-win32 1.3.0.0 release libwdi Zadig and libusb-win32 1.3.0.1 release Nov 8, 2023
@mcuee
Copy link
Contributor Author

mcuee commented Nov 8, 2023

I have to re-open this issue as it still exists with libusb-win32 1.3.0.1 release. So looks like libwdi can not recognize libusb-win32 1.3.0.x version.

@pbatard and @dontech
Please take a look. Thanks.

Capture_libusbwin32

@mcuee
Copy link
Contributor Author

mcuee commented Jan 5, 2024

@dontech

Please help to see if you have the same issue or not. Thanks.

@dontech
Copy link
Contributor

dontech commented Feb 12, 2024

@mcuee how do you rebuild zadig? Just want to make sure I do it the same way,

@pbatard
Copy link
Owner

pbatard commented Feb 12, 2024

@dontech, @mcuee,

Sorry for not having had a chance to look into this. The issue is open so I am planning to do so, but I'm afraid this is not a high priority.

Zadig is built from GitHub actions, so if you clone the project, you should be able to just run the actions script and get the VS2022 artifacts that contain a Zadig executable. Alternatively, you can take a look at https://github.com/pbatard/libwdi/wiki/Compiling-and-debugging-libwdi-or-Zadig which is are beginner level instructions on how to install Visual Studio to build Zadig.

@mcuee
Copy link
Contributor Author

mcuee commented Feb 12, 2024

@dontech

I use VS2022 and just edit config.h to point out to the right locations for my system.

Same issue if I use github action (which uses VS2022). You can checkout the following run.
https://github.com/mcuee/libwdi/actions/runs/7872857879

@mcuee mcuee changed the title libwdi Zadig and libusb-win32 1.3.0.1 release libwdi Zadig and libusb-win32 1.3.0.x release Feb 17, 2024
@mcuee
Copy link
Contributor Author

mcuee commented Feb 17, 2024

The issue still exists with libusb-win32 1.3.0.2 release.
https://github.com/mcuee/libusb-win32/releases/tag/snapshot_1.3.0.2

@dontech
Copy link
Contributor

dontech commented Feb 18, 2024

image

Unable to reproduce. Visual Studio 2022 and version 1.3.0.2

@dontech
Copy link
Contributor

dontech commented Feb 18, 2024

I am pretty sure this is a libwdi/zadig problem. After rebuilding a few times i got this:

image

I think this is a build problem of some kind

@dontech
Copy link
Contributor

dontech commented Feb 18, 2024

OK I found out there are 2 problems:

  1. libwdi has an obvious bug in "embedder_files.h". This causes Zadig/libwdi to use the "install-filter.exe" to get the version info instead of the real DLL it was supposed to use (the "reuse" entries point to a previous entry that is not the same).

  2. libusb-win32 has another obvious bug that causes the install-filter.exe to not have any resources, which should have contained the version info. I will fix this in libusb-win32: install-filter.exe and friends are missing version and other resources mcuee/libusb-win32#64

For libwdi I have added it to my existing pull request:

@pbatard Please pull this: #314

@dontech
Copy link
Contributor

dontech commented Feb 18, 2024

@pbatard I updated the workflows to match the latest libusb0, so we could get the ARM64 binaries

@mcuee
Copy link
Contributor Author

mcuee commented Feb 19, 2024

For libwdi I have added it to my existing pull request:

@pbatard Please pull this: #314

I can confirm that PR #314 fixes this issue. Tested with latest libusb-win32 1.3.0.2 release.

Capture_libusbwin32_libwdi

@dontech
Copy link
Contributor

dontech commented Feb 23, 2024

Either this fixes it or the change in libusb0 should have fixed this. Can be closed now @mcuee

@mcuee mcuee closed this as completed Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants