Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Resource Viewer to selected project #448

Closed
2 tasks
tjcouch-sil opened this issue Sep 26, 2023 · 1 comment
Closed
2 tasks

Open Resource Viewer to selected project #448

tjcouch-sil opened this issue Sep 26, 2023 · 1 comment
Assignees
Labels
extensions team Able to be worked on by extensions team

Comments

@tjcouch-sil
Copy link
Member

tjcouch-sil commented Sep 26, 2023

As a user, I want to be able to select a downloaded project to open with the Resource Viewer so I can see things.


As a quick way to get this working for the tech demo, I propose the following course of action:

  • Create a resourceViewer.open command in the Resource Viewer extension that does the following:
    1. Opens a Select Project dialog to choose which project to open. When the user selects a project, the project id will be returned to the command code
    2. Call papi.webViews.getWebView to get a new Resource Viewer webview. Provide the project id in the options object (extra properties will get carried along to the webview provider function). Return from the command.
    3. When the webview provider receives the request to create the webview, get the project id from the options object (passed from step 2). Set that as part of the webview state.
      - [ ] Set the title to include name of selected project
    4. Adjust the resource viewer webview so it uses the new webview state to get the project ID to show
  • Create a baked-in menu item that calls the new resourceViewer.open command. This lets us avoid implementing the menu design by tech demo time.

Depends on #364, #388, #472

@tjcouch-sil tjcouch-sil added this to the Tech Demo milestone Sep 26, 2023
@tjcouch-sil tjcouch-sil added the extensions team Able to be worked on by extensions team label Sep 26, 2023
@tjcouch-sil tjcouch-sil added the BLOCKED Waiting on something before able to be worked label Oct 9, 2023
@tjcouch-sil tjcouch-sil removed the BLOCKED Waiting on something before able to be worked label Oct 18, 2023
@tombogle tombogle self-assigned this Oct 18, 2023
tombogle added a commit that referenced this issue Oct 19, 2023
Added code to display open project dialog box and to open the new resource viewer with the title bar displaying the selected project
tombogle added a commit that referenced this issue Oct 25, 2023
…d return the webview ID.

Added the selected projectID to the saved webview state
Changed webview to display the USFM for the selected/saved project.
[WIP] Once useProjectData.ChapterUSX is implemented, need to use it and change back to displaying the contents using the read-only UsxEditor
@tombogle
Copy link
Contributor

tombogle commented Oct 25, 2023

BLOCKED: This is now basically done, awaiting the implementation of ChapterUSX as part of #460

@tombogle tombogle added the BLOCKED Waiting on something before able to be worked label Oct 25, 2023
@katherinejensen00 katherinejensen00 removed the BLOCKED Waiting on something before able to be worked label Oct 27, 2023
tombogle added a commit that referenced this issue Oct 31, 2023
…e opened as desired via the menu.

Removed redundant logger.info line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extensions team Able to be worked on by extensions team
Projects
Status: ✅ Done
Development

No branches or pull requests

4 participants