Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create dialog service and Select Project dialog #388

Closed
1 task done
tjcouch-sil opened this issue Aug 18, 2023 · 6 comments · Fixed by #553
Closed
1 task done

Create dialog service and Select Project dialog #388

tjcouch-sil opened this issue Aug 18, 2023 · 6 comments · Fixed by #553
Assignees

Comments

@tjcouch-sil
Copy link
Member

tjcouch-sil commented Aug 18, 2023

As an extension developer, I want to be able to ask the user for some information using existing dialogs in Platform.Bible so it is easy for me to get information from users.


We need to create a dialog service that allows extensions to asynchronously ask the user for a response to something. There are some things we need to put in this service:

  • Select Project dialog

If the linked issues are done first, just connect them into this dialog service. If not, just make sure they are put in with the issue in which they are to be created.

@tjcouch-sil
Copy link
Member Author

I believe this is necessary for opening the Resource Viewer or Text Collection with a specified set of projects for the tech demo. @GlennPruitt

@irahopkinson
Copy link
Contributor

Good UX means dialog primary buttons should always convey an action to take ususally using a verb. A secondary button (if it exists) is almost always the verb "Cancel". That means we shouldn't have any Yes/No dialogs. Remember that users essentially hate confirmation dialogs, usually don't read them and just want to get rid of them as quickly as possible. So confirmation dialogs should only be used rarely when it is crucial. Rather than use a confirmation dialog it is better to allow the user to undo the action or easily recreate the data so they have confidence to discover what things do.

@tjcouch-sil
Copy link
Member Author

Select Multiple Projects split off to #514

@tjcouch-sil tjcouch-sil changed the title Create dialog service Create dialog service and Select Project dialog Oct 4, 2023
@tjcouch-sil tjcouch-sil self-assigned this Oct 9, 2023
@tjcouch-sil
Copy link
Member Author

tjcouch-sil commented Oct 10, 2023

  • Close dialog on confirm
  • Close dialog on X
  • List the actually installed projects
  • Default float width/height
  • DialogTab class
    • Type - how can we make this not circularly dependent with dialog service?
    • Component
    • Default width/height
    • loadDialog
    • saveDialog
  • Genericize to papi.dialogs.get or something
  • Mapped types
  • rename to selectProject
  • Revise file structure

@tjcouch-sil
Copy link
Member Author

tjcouch-sil commented Oct 13, 2023

Created #551 for extensions creating custom webview dialogs

@tjcouch-sil
Copy link
Member Author

Documentation:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
2 participants