Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Missing finedesign in Shares Panel #2 #7402

Merged
merged 15 commits into from
Aug 8, 2022
Merged

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Aug 3, 2022

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Aug 3, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear mentioned this pull request Aug 3, 2022
11 tasks
@AlexAndBear AlexAndBear marked this pull request as ready for review August 3, 2022 15:40
@ownclouders
Copy link
Contributor

ownclouders commented Aug 3, 2022

Results for oC10SharingPermission https://drone.owncloud.com/owncloud/web/27382/35/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L47.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L47.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L48.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L48.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L49.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L49.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L50.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L50.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L51.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L51.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L52.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L52.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L53.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L53.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L54.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L54.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L55.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L55.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L56.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L56.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L57.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L57.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L58.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L58.png

webUISharingPermissionsUsers-sharePermissionsUsers_feature-L100.png

webUISharingPermissionsUsers-sharePermissionsUsers_feature-L100.png

webUISharingPermissionsUsers-sharePermissionsUsers_feature-L101.png

webUISharingPermissionsUsers-sharePermissionsUsers_feature-L101.png

webUISharingPermissionsUsers-sharePermissionsUsers_feature-L102.png

webUISharingPermissionsUsers-sharePermissionsUsers_feature-L102.png

webUISharingPermissionsUsers-sharePermissionsUsers_feature-L103.png

webUISharingPermissionsUsers-sharePermissionsUsers_feature-L103.png

webUISharingPermissionsUsers-sharePermissionsUsers_feature-L156.png

webUISharingPermissionsUsers-sharePermissionsUsers_feature-L156.png

webUISharingPermissionsUsers-sharePermissionsUsers_feature-L157.png

webUISharingPermissionsUsers-sharePermissionsUsers_feature-L157.png

webUISharingPermissionsUsers-sharePermissionsUsers_feature-L158.png

webUISharingPermissionsUsers-sharePermissionsUsers_feature-L158.png

webUISharingPermissionsUsers-sharePermissionsUsers_feature-L161.png

webUISharingPermissionsUsers-sharePermissionsUsers_feature-L161.png

webUISharingPermissionsUsers-sharePermissionsUsers_feature-L99.png

webUISharingPermissionsUsers-sharePermissionsUsers_feature-L99.png

@AlexAndBear AlexAndBear marked this pull request as draft August 3, 2022 16:04
@AlexAndBear AlexAndBear marked this pull request as ready for review August 4, 2022 10:35
@AlexAndBear AlexAndBear marked this pull request as draft August 4, 2022 11:07
@AlexAndBear AlexAndBear force-pushed the issues/7340-2 branch 2 times, most recently from 8459ae7 to d427bb5 Compare August 5, 2022 14:00
Copy link
Contributor

@tbsbdr tbsbdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@AlexAndBear AlexAndBear marked this pull request as ready for review August 5, 2022 14:08
@AlexAndBear AlexAndBear changed the title Missing finedesign in Shares Panel #2 [full-ci] Missing finedesign in Shares Panel #2 Aug 5, 2022
@AlexAndBear
Copy link
Contributor Author

AlexAndBear commented Aug 5, 2022

While doing investigations e2e tests seems to be broken by ods bump
https://drone.owncloud.com/owncloud/web/27375/11/18

#7412

FIXED BY:
8b1e592

Still a weird thing...

@sonarcloud
Copy link

sonarcloud bot commented Aug 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.3% 83.3% Coverage
0.0% 0.0% Duplication

Comment on lines -300 to +307
selector: '.files-collaborators-collaborator-additional-info'
selector:
'//div[contains(@class, "share-access-details-drop")]//dt[contains(text(),"Additional info")]/following-sibling::dd[1]',
locateStrategy: 'xpath'
},
collaboratorShareType: {
selector: '.files-collaborators-collaborator-share-type'
selector:
'//div[contains(@class, "share-access-details-drop")]//dt[contains(text(),"Type")]/following-sibling::dd[1]',
locateStrategy: 'xpath'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 💪 🎨

@AlexAndBear AlexAndBear merged commit 70bd46d into master Aug 8, 2022
@delete-merged-branch delete-merged-branch bot deleted the issues/7340-2 branch August 8, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing finedesign in Shares Panel
4 participants