Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing finedesign in Shares Panel #7340

Closed
11 tasks done
tbsbdr opened this issue Jul 26, 2022 · 10 comments · Fixed by #7402
Closed
11 tasks done

Missing finedesign in Shares Panel #7340

tbsbdr opened this issue Jul 26, 2022 · 10 comments · Fixed by #7402
Assignees
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working

Comments

@tbsbdr
Copy link
Contributor

tbsbdr commented Jul 26, 2022

Steps to reproduce

1.login at https://ocis.ocis-web.latest.owncloud.works/
2. share a fiel with several people
3. create 4 links for the same resource
4. Shares panel looks not well visually tidied up yet

Screenshot 000098

Expected behaviour

  • remove top- and bottom seperators from header
  • remove resource size and modified date from header
  • Add contextual help "?" next to "Share with people"
  • move helper text into "?"
  • round corners for the group-background fix: group avatars by long group names in sidebar owncloud-design-system#2242
  • adjust avatar size to 36 px
  • adjust avatar initials to regular font weight (not bold)
  • center-vertical 3-dots button, "via" and exp. date (related to the whole collaborator-item)
  • reduce whitespace between resource-name and "Share with people" area
  • "Via " should get truncated
  • Adjust Access Details so that it looks like the Context-Helper UI

screens are not 100% up to date, as we reworked the position of the roles and removed the user-types, but should give an impression what the design goal is.

Screenshot 000182@2x

Screenshot 000099
Screenshot 000100

Helper Access details

(outlook - we could show more details in the future. currently this is mainly used to keep the shares-list clean, i.e. let not so important infos take a backseat here in the Access details)

Texts

  • Name
  • Additional info
  • Access expires ("No" or <Date>)
  • Shared on
  • Invited by
  • Recent view or download of the share ("Never" or <Date>)

Learn more (Will be documented as soon as we extend the infos)

@tbsbdr tbsbdr added Priority:p3-medium Normal priority Type:Bug Something isn't working labels Jul 26, 2022
@kulmann kulmann added this to the 2.0.0 General Availability milestone Jul 27, 2022
@AlexAndBear AlexAndBear self-assigned this Jul 28, 2022
@kulmann
Copy link
Member

kulmann commented Aug 1, 2022

Would like to see written down acceptance criteria here. Otherwise the design screenshots leave too much room for interpretation.

@tbsbdr
Copy link
Contributor Author

tbsbdr commented Aug 1, 2022

update: added ACs (checklist in initial post) to make changes more transparent

@tbsbdr
Copy link
Contributor Author

tbsbdr commented Aug 1, 2022

regarding #7372 :

"Via" needs some truncation:

flip order of the items in the collaborators item; should be "via", then "exp. Date"  

reduce whitespace between resource-name and "Share with people" area. should be like:

Screenshot 000186@2x

@AlexAndBear
Copy link
Contributor

AlexAndBear commented Aug 2, 2022

TBD in another PR

@AlexAndBear
Copy link
Contributor

Follow up: #7402

@AlexAndBear
Copy link
Contributor

AlexAndBear commented Aug 3, 2022

@tbsbdr
I set the distance between Navbar-header, Navbar-resource-name and Navbar-body to 10px.
This is the same padding (10px) we already used for the left and right.

However, the distance between Share with people and Share via link is 16px.

So we have the option to:

  • Set the navbar distances to 16px (IHMO too much)
  • Set the Share with people and Share via link distance to 10px
  • Leave it as it is (Best solution IHMO, as it looks good now)

image

@tbsbdr
Copy link
Contributor Author

tbsbdr commented Aug 4, 2022

ack

👍 nice, thanks - also for stating the other options

@tbsbdr
Copy link
Contributor Author

tbsbdr commented Aug 4, 2022

Update: added "Adjust Access Details so that it looks like the Context-Helper UI"
moved here from #7331

@kulmann
Copy link
Member

kulmann commented Aug 5, 2022

What about using our theme css variables for margin/padding? based on a grid of 8px. Honestly not sure where we should hardcode margins and where to use the variables, but my gut feeling is that we should use the css variables here.

@AlexAndBear
Copy link
Contributor

AlexAndBear commented Aug 5, 2022

@kulmann Totally agree and implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants