Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finedesign share panel #7372

Merged
merged 10 commits into from
Aug 1, 2022
Merged

Finedesign share panel #7372

merged 10 commits into from
Aug 1, 2022

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Jul 29, 2022 •
edited by kulmann
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Jul 29, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

Results for oCISSharingInternal2 https://drone.owncloud.com/owncloud/web/27175/61/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingInternalUsers-shareWithUsers_feature-L139.png

webUISharingInternalUsers-shareWithUsers_feature-L139.png

webUISharingInternalUsers-shareWithUsers_feature-L322.png

webUISharingInternalUsers-shareWithUsers_feature-L322.png

webUISharingInternalUsers-shareWithUsers_feature-L331.png

webUISharingInternalUsers-shareWithUsers_feature-L331.png

webUISharingInternalUsersCollaborator-shareWithUsers_feature-L34.png

webUISharingInternalUsersCollaborator-shareWithUsers_feature-L34.png

webUISharingInternalUsersCollaborator-shareWithUsers_feature-L35.png

webUISharingInternalUsersCollaborator-shareWithUsers_feature-L35.png

webUISharingInternalUsersCollaborator-shareWithUsers_feature-L36.png

webUISharingInternalUsersCollaborator-shareWithUsers_feature-L36.png

webUISharingInternalUsersCollaborator-shareWithUsers_feature-L37.png

webUISharingInternalUsersCollaborator-shareWithUsers_feature-L37.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@AlexAndBear AlexAndBear marked this pull request as ready for review July 29, 2022 14:17
@AlexAndBear AlexAndBear changed the title Redesign share panel Finedesign share panel Jul 29, 2022
kulmann
kulmann requested changes Aug 1, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see quite some code deletion in this PR that don't have clear acceptance criteria in the linked issue. Would like to clarify with @tbsbdr here or in the issue if e.g. removing the file size info or invite help text is really intended or just missing in the design.

@kulmann
Copy link
Member

kulmann commented Aug 1, 2022

Please note that I changed the PR description to state Works towards #7340 instead of fixing it, because rearranging the dropdowns will happen in another PR #7365

@AlexAndBear
Copy link
Contributor Author

@kulmann This has been spoken through in detail, all code deletion was done with intention

@kulmann
Copy link
Member

kulmann commented Aug 1, 2022

@kulmann This has been spoken through in detail, all code deletion was done with intention

Then let's please take the time and write down the decisions in the issue

@tbsbdr tbsbdr mentioned this pull request Aug 1, 2022
Closed
11 tasks
@kulmann
Copy link
Member

kulmann commented Aug 1, 2022 •
edited
Loading

Needs a rebase now to solve conflicting files issues

@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

72.2% 72.2% Coverage
0.0% 0.0% Duplication

@AlexAndBear
Copy link
Contributor Author

done

kulmann
kulmann approved these changes Aug 1, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👍

...es/src/components/SideBar/Shares/Collaborators/InviteCollaborator/InviteCollaboratorForm.vue
return this.$gettext('Add new person by name, email or federation IDs')
}
const cernFeatures = !!this.configuration?.options?.cernFeatures
return cernFeatures
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elizavetaRa @diocas decision was made to remove the description message below the sharing invite form. If you can't drop the line from your UI we'll have to find a different solution. Please reach out then.

@kulmann kulmann merged commit 77cc016 into master Aug 1, 2022
@delete-merged-branch delete-merged-branch bot deleted the issues/7340 branch August 1, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexAndBear @ownclouders @kulmann