Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] More app top bar fixes #7362

Merged
merged 14 commits into from
Jul 28, 2022
Merged

[full-ci] More app top bar fixes #7362

merged 14 commits into from
Jul 28, 2022

Commits on Jul 28, 2022

  1. Move Resource interface to web-client

    @dschmidt
    dschmidt committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    edcf0e7 View commit details
    Browse the repository at this point in the history

  2. Add getFileResource helper to AppFileHandling composable

    @dschmidt
    dschmidt committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    ebdc3f6 View commit details
    Browse the repository at this point in the history

  3. web-app-external: use getFileResource helper

    @dschmidt
    dschmidt committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    d938613 View commit details
    Browse the repository at this point in the history

  4. Fix permissions type in Resource interface

    @dschmidt
    dschmidt committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    39dda69 View commit details
    Browse the repository at this point in the history

  5. web-app-pdf-viewer: make AppTopBar always visible

    @dschmidt
    dschmidt committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    ec2f326 View commit details
    Browse the repository at this point in the history

  6. web-app-pdf-viewer: use getFileResource helper

    @dschmidt
    dschmidt committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    2b89869 View commit details
    Browse the repository at this point in the history

  7. web-app-text-editor: make AppTopBar always visible

    @dschmidt
    dschmidt committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    ee19e91 View commit details
    Browse the repository at this point in the history

  8. web-app-text-editor: add error display

    @dschmidt
    dschmidt committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    184c6b4 View commit details
    Browse the repository at this point in the history

  9. web-app-text-editor: use getFileResource helper

    @dschmidt
    dschmidt committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    22e6173 View commit details
    Browse the repository at this point in the history

  10. web-app-preview: simplify raw file loading 

    ... by moving complexity to useAppFileHandling composable
    @dschmidt
    dschmidt committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    95951e3 View commit details
    Browse the repository at this point in the history

  11. web-app-pdf-viewer: Use getUrlForResource

    @dschmidt
    dschmidt committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    1a422d6 View commit details
    Browse the repository at this point in the history

  12. web-app-preview: Use revokeUrl from file handling composable

    @dschmidt
    dschmidt committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    aab7fe7 View commit details
    Browse the repository at this point in the history

  13. Add current PR to unreleased changelog item

    @dschmidt
    dschmidt committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    7df9bb7 View commit details
    Browse the repository at this point in the history

  14. useAppFileHandling.getUrlForResource: add disposition option 

    which can be either inline or attachment and can be used to define the purpose of the retrieved url.
Chrome allows us to use signed/downloadURLs for video playback although they send a Content-Disposition header, so we can just use a signed url and don't need to create a blob url for this.
We cannot embed PDFs in the same way, as they trigger downloads. So we need to create a blob url for those.

If you need a download url, it's fine (or even desired) for the response
to contain the Content-Disposition header.
    @dschmidt
    dschmidt committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    1f15bd6 View commit details
    Browse the repository at this point in the history