[full-ci] More app top bar fixes #7362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
dschmidt
commented
Jul 27, 2022
| import { MaybeRef } from '../../utils' | ||
| import { ClientService } from '../../services' | ||
| import { DavProperties } from '../../constants' | ||
| import { buildResource } from 'files/src/helpers/resources' |
There was a problem hiding this comment.
This should not stay in files, but where do we want this and a bunch of other helpers? in web-pkg or web-client?
Let's discuss tomorrow...
|
Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/27127/67/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUIUpload-upload_feature-L94.png |
|
Results for oC10IntegrationApp1 https://drone.owncloud.com/owncloud/web/27099/72/1 |
dschmidt
force-pushed
the
more_app_top_bar_fixes
branch
2 times, most recently
from
605d033
to
ab40f6e
Compare
... by moving complexity to useAppFileHandling composable
dschmidt
force-pushed
the
more_app_top_bar_fixes
branch
from
ab40f6e
to
f59928a
Compare
which can be either inline or attachment and can be used to define the purpose of the retrieved url. Chrome allows us to use signed/downloadURLs for video playback although they send a Content-Disposition header, so we can just use a signed url and don't need to create a blob url for this. We cannot embed PDFs in the same way, as they trigger downloads. So we need to create a blob url for those. If you need a download url, it's fine (or even desired) for the response to contain the Content-Disposition header.
dschmidt
force-pushed
the
more_app_top_bar_fixes
branch
from
f59928a
to
1f15bd6
Compare
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: