[full-ci] Initial implementation of archiver v2 #5832

kulmann · 2021-09-23T08:28:24Z

Initial implementation of archiver v2 (REVA) for authenticated contexts. Public links are not supported, yet.

Description

Related Issue

Motivation and Context

Being able to download folders

How Has This Been Tested?

not yet

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests

Checklist:

Code changes
Unit tests added
Acceptance tests added
Documentation ticket raised:

Open tasks:

Reva capabilities need to be brought to oCIS Archiver and app provider capabilities ocis#2529
archiver config needs to be merged in oCIS Expose configuration for the reva archiver ocis#2509
updated archiver implementation in reva needs to be merged Add support for resource id to the archiver cs3org/reva#2100
separate webUIFilesActionMenu/fileFolderActionMenu.feature:14 into an oCIS and an oC10 test (archiver only exists with ocis)
~~move archiverService initialization to the initialize hook once [full-ci] Init store and auth as early as possible #5874 is merged~~

update-docs · 2021-09-23T08:28:27Z

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

packages/web-app-files/src/components/AppBar/SelectedResources/BatchActions.vue

ownclouders · 2021-10-04T10:57:15Z

Results for oC10SharingInternalUsers https://drone.owncloud.com/owncloud/web/19381/25/1
The following scenarios passed on retry:

webUISharingInternalUsersShareWithPage/shareWithUsers.feature:91

individual-it · 2021-10-04T13:44:30Z

tests/acceptance/features/webUIFilesActionMenu/fileFolderActionMenu.feature

@@ -19,6 +19,7 @@ Background: prepare user and files
    And only the following items with default items should be visible in the actions menu on the webUI
      | items                     |
      | open folder               |
+      | download folder           |


this test fails AssertionError [ERR_ASSERTION]: only 'open folder,download folder' actions menu item(s) was expected to be visible but found 'open folder' instead.

pascalwengerter · 2021-09-30T08:51:31Z

packages/web-app-files/tests/unit/components/AppBar/SelectedResources/BatchActions.spec.js

            copyButton = wrapper.find(elSelector.copyButton)
            moveButton = wrapper.find(elSelector.moveButton)
            deleteButton = wrapper.find(elSelector.deleteButton)
          })

          it('should display the action buttons', () => {
-            expect(actionButtons.length).toEqual(3)
+            expect(downloadButton.exists()).toBeTruthy()


Shouldn't checking for the text of an element be enough (test fails if it doesn't exist since it can't find the text)?

pascalwengerter · 2021-09-30T08:54:09Z

packages/web-app-files/tests/unit/services/archiver.spec.ts

+        it('is announcing itself as available', () => {
+          expect(service.available).toBe(true)
+        })
+        it('uses the highest major version', () => {


Suggested change

it('uses the highest major version', () => {

it('uses the highest major version that is enabled', () => {

Optional clarification

pascalwengerter · 2021-10-04T11:42:20Z

tests/acceptance/features/webUIFilesActionMenu/fileFolderActionMenu.feature

@@ -19,6 +19,7 @@ Background: prepare user and files
    And only the following items with default items should be visible in the actions menu on the webUI
      | items                     |
      | open folder               |
+      | download folder           |


Seems to fail in a OC10 pipeline which makes sense (since the download action doesn't get rendered into those actions based on capabilities?)

will that be added in oc10? If yes, then the test need to he added to the expected to fail list, if not, need to split the scenario and one tagged with @skipOnOC10 and one with @notToImplementOnOCIS

pascalwengerter

LGTM 🗃️ if CI agrees

…nd and boot logic needs to be improved. oids-callback page is in vue so the mounted hook was already called.

sonarcloud · 2021-10-05T16:12:29Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
1 Security Hotspot
0 Code Smells

40.4% Coverage
0.0% Duplication

ownclouders · 2021-10-05T16:41:20Z

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/19427/12/1
The following scenarios passed on retry:

webUIFilesActionMenu/versions.feature:36

kulmann requested review from fschade and pascalwengerter as code owners September 23, 2021 08:28

kulmann marked this pull request as draft September 23, 2021 08:28

kulmann force-pushed the archive-download branch from bde5577 to 56aa196 Compare September 23, 2021 13:19

kulmann mentioned this pull request Sep 23, 2021

Documentation for archiver cs3org/reva#2096

Closed

kulmann force-pushed the archive-download branch from b26cd4e to c169c63 Compare September 24, 2021 12:59

pascalwengerter reviewed Sep 28, 2021

View reviewed changes

packages/web-app-files/src/components/AppBar/SelectedResources/BatchActions.vue Outdated Show resolved Hide resolved

kulmann mentioned this pull request Sep 28, 2021

Add support for resource id to the archiver cs3org/reva#2100

Merged

kulmann marked this pull request as ready for review September 29, 2021 12:09

kulmann force-pushed the archive-download branch from 447a714 to be68ccd Compare September 29, 2021 12:11

kulmann changed the title ~~Initial implementation of archiver v2~~ [full-ci] Initial implementation of archiver v2 Sep 29, 2021

kulmann force-pushed the archive-download branch 2 times, most recently from 8d5faf0 to 9a115d9 Compare October 1, 2021 12:07

pascalwengerter mentioned this pull request Oct 1, 2021

Enable archive download on public links #5862

Closed

kulmann force-pushed the archive-download branch from 0c7ea9a to 4c6d0ad Compare October 4, 2021 09:32

individual-it reviewed Oct 4, 2021

View reviewed changes

pascalwengerter reviewed Oct 4, 2021

View reviewed changes

individual-it mentioned this pull request Oct 4, 2021

webUISharingInternalUsersShareWithPage/shareWithUsers.feature:91 is failing lot in CI #5627

Closed

kulmann mentioned this pull request Oct 4, 2021

Release 4.3.0 #5872

Closed

25 tasks

pascalwengerter approved these changes Oct 4, 2021

View reviewed changes

SwikritiT mentioned this pull request Oct 5, 2021

Bump latest commit ids [Sep 27 - Oct 8] owncloud/QA#690

Closed

5 tasks

kulmann added 7 commits October 5, 2021 13:41

Initial implementation of archiver v2

24ec191

Switch to resource id based archiver backend

7dfe08c

Disable archive download on public files routes for now

30aeec1

Trigger download from blob

7d18442

Fix availability check in archiverService

838336f

Add unit tests for archiverService

94b9cd9

Use single file download in batch actions if only 1 file selected

a1b7824

kulmann and others added 14 commits October 5, 2021 13:41

Add tests for downloadAsArchive helper

ae9cc59

Add changelog

4a57c29

Fix unit tests regarding download changes

95dc708

Fix code smell

332a051

Make linter happy

6b4a52a

Switch to client side presigned url for archive download

f878e21

Update ocis commit id for drone

deb7a51

Add issue links to changelog

39208c4

Fix snapshots

465e7e2

Fix snapshot tests

01813a2

Downgrade semver to 6.x.x because of incompatibilities

cccb27f

Simplify imports

a8f2f3e

Fix file actions test

13174b6

Split actions on folders test into oc10 and ocis tests

a11c59e

fschade force-pushed the archive-download branch from 2f736b9 to a11c59e Compare October 5, 2021 11:41

reload window after login callback got fired, this is just a workarou…

926863c

…nd and boot logic needs to be improved. oids-callback page is in vue so the mounted hook was already called.

fschade force-pushed the archive-download branch from 614172c to 926863c Compare October 5, 2021 16:03

fschade merged commit 1032246 into master Oct 5, 2021

delete-merged-branch bot deleted the archive-download branch October 5, 2021 17:00

fschade mentioned this pull request Oct 7, 2021

Archive download for public links #5884

Closed

JammingBen mentioned this pull request Jan 31, 2022

Add space front page & bump SDK to v2.0.0 #6287

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[full-ci] Initial implementation of archiver v2 #5832

[full-ci] Initial implementation of archiver v2 #5832

kulmann commented Sep 23, 2021 •

edited by fschade

Loading

update-docs bot commented Sep 23, 2021

ownclouders commented Oct 4, 2021

individual-it Oct 4, 2021

pascalwengerter Sep 30, 2021

pascalwengerter Sep 30, 2021

pascalwengerter Oct 4, 2021

individual-it Oct 4, 2021

pascalwengerter left a comment

sonarcloud bot commented Oct 5, 2021

ownclouders commented Oct 5, 2021

	it('uses the highest major version', () => {
	it('uses the highest major version that is enabled', () => {

[full-ci] Initial implementation of archiver v2 #5832

[full-ci] Initial implementation of archiver v2 #5832

Conversation

kulmann commented Sep 23, 2021 • edited by fschade Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

Checklist:

Open tasks:

update-docs bot commented Sep 23, 2021

ownclouders commented Oct 4, 2021

individual-it Oct 4, 2021

Choose a reason for hiding this comment

pascalwengerter Sep 30, 2021

Choose a reason for hiding this comment

pascalwengerter Sep 30, 2021

Choose a reason for hiding this comment

pascalwengerter Oct 4, 2021

Choose a reason for hiding this comment

individual-it Oct 4, 2021

Choose a reason for hiding this comment

pascalwengerter left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Oct 5, 2021

ownclouders commented Oct 5, 2021

kulmann commented Sep 23, 2021 •

edited by fschade

Loading