Archiver and app provider capabilities

[wkloucek]

Description

Adds the archiver and app provider to the ocs capabilities.
Removes unused structs, which already live in REVA

Related Issue

• Needs add archiver and app provider capabilities cs3org/reva#2088
• Fixes [Question] Add capability for app provider? #2482

Motivation and Context

How Has This Been Tested?

• locally:

curl --insecure 'https://localhost:9200/ocs/v1.php/cloud/capabilities?format=json' -u einstein:relativity | jq .
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1715  100  1715    0     0   2436      0 --:--:-- --:--:-- --:--:--  2436
{
  "ocs": {
    "meta": {
      "status": "ok",
      "statuscode": 100,
      "message": "OK"
    },
    "data": {
      "capabilities": {
        "core": {
          "pollinterval": 60,
          "webdav-root": "remote.php/webdav",
          "status": {
            "installed": true,
            "maintenance": false,
            "needsDbUpgrade": false,
            "version": "10.0.11.5",
            "versionstring": "10.0.11",
            "edition": "community",
            "productname": "reva"
          },
          "support-url-signing": true
        },
        "checksums": {
          "supportedTypes": [
            "sha1",
            "md5",
            "adler32"
          ],
          "preferredUploadType": "SHA1"
        },
        "files": {
          "privateLinks": false,
          "bigfilechunking": false,
          "undelete": true,
          "versioning": true,
          "favorites": false,
          "blacklisted_files": [],
          "tus_support": {
            "version": "1.0.0",
            "resumable": "1.0.0",
            "extension": "creation,creation-with-upload",
            "max_chunk_size": 0,
            "http_method_override": ""
          },
          "archivers": [
            {
              "enabled": true,
              "version": "2.0",
              "formats": [
                "tar",
                "zip"
              ],
              "archiver_url": "/archiver"
            }
          ],
          "app_providers": [
            {
              "enabled": true,
              "version": "1.0",
              "apps_url": "/app/list",
              "open_url": "/app/open"
            }
          ]
        },
        "dav": {
          "chunking": "",
          "trashbin": "1.0",
          "reports": [
            "search-files"
          ],
          "chunkingParallelUploadDisabled": false
        },
        "files_sharing": {
          "api_enabled": true,
          "resharing": true,
          "group_sharing": true,
          "auto_accept_share": true,
          "share_with_group_members_only": true,
          "share_with_membership_groups_only": true,
          "search_min_length": 3,
          "default_permissions": 22,
          "user_enumeration": {
            "enabled": true,
            "group_members_only": true
          },
          "federation": {
            "outgoing": true,
            "incoming": true
          },
          "public": {
            "enabled": true,
            "send_mail": true,
            "social_share": true,
            "upload": true,
            "multiple": true,
            "supports_upload_only": true,
            "password": {
              "enforced_for": {
                "read_only": true,
                "read_write": true,
                "upload_only": true
              },
              "enforced": true
            },
            "expire_date": {
              "enabled": false
            }
          },
          "user": {
            "send_mail": true,
            "profile_picture": false
          }
        }
      },
      "version": {
        "major": 10,
        "minor": 0,
        "micro": 11,
        "string": "10.0.11",
        "edition": "reva"
      }
    }
  }
}

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

[jvillafanez]

For the archiver, it has a maximum number of files and a maximum size that I think they should be in the capabilities. The client could prevent requests that we know that will fail.

[wkloucek]

For the archiver, it has a maximum number of files and a maximum size that I think they should be in the capabilities. The client could prevent requests that we know that will fail.

Good point 👍 Needs changes in REVA though...

[kulmann]

For the archiver, it has a maximum number of files and a maximum size that I think they should be in the capabilities. The client could prevent requests that we know that will fail.

Good point 👍 Needs changes in REVA though...

Yes, good idea for improvement 👍 but please let's get this PR merged first, then improve it (IMO right away ;-) ).

[jvillafanez]

I'm not sure about the changes in the go.mod file, but the rest looks good to me.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[kulmann]

LGTM 👍