Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement thumbnail support for txt files #1988

Merged
merged 1 commit into from
Apr 30, 2021
Merged

implement thumbnail support for txt files #1988

merged 1 commit into from
Apr 30, 2021

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Apr 29, 2021

Implemented support for thumbnails for txt files in the thumbnails service.

Should solve many expected failures regarding thumbnails.

@C0rby C0rby requested review from refs and wkloucek April 29, 2021 10:00
@C0rby C0rby self-assigned this Apr 29, 2021
@C0rby C0rby requested a review from LukasHirt as a code owner April 29, 2021 10:00
@C0rby C0rby force-pushed the thumbnails-txt-files branch 2 times, most recently from 0570376 to f0968f6 Compare April 29, 2021 11:45
@sonarcloud
Copy link

sonarcloud bot commented Apr 29, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
7.0% 7.0% Duplication

wkloucek
wkloucek approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@wkloucek wkloucek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
image

@C0rby C0rby merged commit 8f43938 into master Apr 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the thumbnails-txt-files branch April 30, 2021 06:48
ownclouders pushed a commit that referenced this pull request Apr 30, 2021
@C0rby
commit 8f43938
228d70f 
Merge: dd75e1c 12b4a26
Author: David Christofas <C0rby@users.noreply.github.com>
Date:   Fri Apr 30 08:48:44 2021 +0200

    Merge pull request #1988 from owncloud/thumbnails-txt-files

    implement thumbnail support for txt files
This was referenced Apr 30, 2021
Closed
Closed
@renovate renovate bot mentioned this pull request Jun 7, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkloucek wkloucek wkloucek approved these changes

@refs refs Awaiting requested review from refs

@LukasHirt LukasHirt Awaiting requested review from LukasHirt

Assignees

@C0rby C0rby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@C0rby @wkloucek