Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requesting a text file preview #200

Closed
swoichha opened this issue Apr 9, 2020 · 4 comments
Closed

Requesting a text file preview #200

swoichha opened this issue Apr 9, 2020 · 4 comments
Labels
Category:Defect Existing functionality is not working as expected Type:Bug

Comments

@swoichha
Copy link
Contributor

swoichha commented Apr 9, 2020

Steps to reproduce

  • Create an user and upload an text file
  • User downloads the preview of text file with width "32" and height "32"
    e.g. curl http://172.17.0.1:9140/remote.php/dav/files/admin/lorem.txt\?x\=32\&y\=32\&forceIcon\=0\&preview\=1 -u admin:admin -v --output test.jpg

Expected

  • Preview of width "32" and height "32" should be downloaded

Actual

  • Preview of size 0 bytes is downloaded
@individual-it
Copy link
Member

issues might be that we are using the wrong port https://github.com/owncloud/ocis-thumbnails/issues/29 & that the previews require, but should not the etag https://github.com/owncloud/ocis-thumbnails/issues/28

@swoichha
Copy link
Contributor Author

swoichha commented Aug 4, 2020

Currently thumbnail service doesn't work with basic auth. So, we cannot get preview using 9200 and using 9140 gives the actual file instead of preview as the thumbnail service and the rest of the webdav service are still separated in two services and until they are merge we can't access the thumbnail service under the port 9140. See https://github.com/owncloud/ocis-thumbnails/issues/39

@refs refs added the bug label Jan 12, 2021
@settings settings bot removed the bug label Jan 12, 2021
@refs refs added the Category:Defect Existing functionality is not working as expected label Jan 13, 2021
@settings settings bot removed the p3-medium label Apr 7, 2021
@exalate-issue-sync
Copy link

exalate-issue-sync bot commented Apr 13, 2021

Willy Kloucek commented: implementing txt previews would remove lots of expected failures -> #1913

@exalate-issue-sync
Copy link

David Christofas commented: Thumbnail support for .txt files was implemented here: #1988

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Defect Existing functionality is not working as expected Type:Bug
Projects
None yet
Development

No branches or pull requests

3 participants