Skip to content
This repository has been archived by the owner on Jan 18, 2021. It is now read-only.

add new config options for the http client #330

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

butonic
Copy link
Member

@butonic butonic commented Jul 1, 2020

after cs3org/reva#914 the internal certificates are checked for validity, which causes the acceptance tests to fail.

this PR also adresses owncloud/ocis#120 by increasing the timeout for internal http requests to 24h, but needs to be brought to ocis

  • make timeout configurable
  • make insecure configurable
  • think about making insecure and timeout a shared config option in reva

it just hardcodes the values back (in the config) to what was previously hardcoded in reva, so I did not add a changelog.

related:

@update-docs
Copy link

update-docs bot commented Jul 1, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

pkg/flagset/gateway.go Outdated Show resolved Hide resolved
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic requested a review from micbar July 1, 2020 20:35
@butonic butonic self-assigned this Jul 1, 2020
@butonic butonic added the enhancement New feature or request label Jul 1, 2020
@IljaN IljaN self-requested a review July 1, 2020 21:07
@butonic butonic merged commit ac26af3 into owncloud:master Jul 1, 2020
@butonic butonic deleted the add-new-config-options branch July 1, 2020 21:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants