Introduce Options for the httpclient #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butonic
force-pushed
the
make-httpclient-configurable
branch
from
686920f
to
5ecd70f
Compare
butonic
force-pushed
the
make-httpclient-configurable
branch
from
5ecd70f
to
bbb15dc
Compare
|
@butonic Can you rebase? |
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic
force-pushed
the
make-httpclient-configurable
branch
from
bbb15dc
to
cda1ce5
Compare
labkode
approved these changes
Jul 1, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, slow up and downloads fail because the timeout is currently hardcoded to 10 sec.
This PR allows configuring the HTTPClient as needed. It also introduces
timeoutandinsecureconfig options for the oc services. I tried not change the behavior or introduce config options when a config struct was not available, eg for the CLI up and download commands.For mentix I updated the example config.
I also made the oidc client use the rhttp httpclient, so it should also send traces.