Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]Added script to report closed issues in expected failure file #40377

Merged
merged 4 commits into from
Sep 21, 2022

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Sep 20, 2022

Description

This PR Adds bash script to report or find the issue that are closed but are still in the expected to failure file (In any Owncloud repository).

Related issue

owncloud/QA#716

@phil-davis
Copy link
Contributor

Note: this script is not being used in CI (of core, or oCIS or reva...) because it would cause unexpected CI fails if someone closes an issue that is in an expected-failures file, and that is outside the real control of the CI of PRs. We don't want developers to get their PRs "broken" by "external" things like that.

We can use this script manually when we want to. In the future, if it seems worthwhile, we could put it in nightly CI - but first lets use it manually.

@SagarGi SagarGi force-pushed the lint-closed-expected-to-failure-file branch from a8ba32c to 084e5f9 Compare September 21, 2022 03:17
@phil-davis
Copy link
Contributor

phil-davis commented Sep 21, 2022

I adjusted the indent to always use tabs. And added a check for invalid issue numbers. I will review and test again later today.

@phil-davis phil-davis changed the title [tests-only][full-ci]Added script to report closed issues in expected to failure file [tests-only][full-ci]Added script to report closed issues in expected failure file Sep 21, 2022
@phil-davis
Copy link
Contributor

I added a few more checks for unusual things:

  1. if the ( ) pair has space inside the brackets (as well as maybe a link). We want to consistently not have the space, and be able to reasonably reliably parse what should be a link.
  2. detect when the issue "state" returns "null" or nothing at all. That happens for non-existent links, or some link to some other random place on the internet that does not return the JSON that we are hoping for.

The objective is to also try and find supposed "links to issues" that are "just plain wrong".

@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 271bb43 into master Sep 21, 2022
@delete-merged-branch delete-merged-branch bot deleted the lint-closed-expected-to-failure-file branch September 21, 2022 13:07
@phil-davis
Copy link
Contributor

This will be used to check expected-failures files: owncloud/ocis#4635

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants