[tests-only] [full-ci] Check for newline at end of expected-failures file

[phil-davis]

Description

See discussion in cs3org/reva#2482

If the last line in an expected-failures file does not have a newline at the end then the test-runner run.sh script loop:

while read SUITE_SCENARIO
  do
    ...
  done < ${EXPECTED_FAILURES_FILE}

does not actually read the last line. That is a "feature" of the definition of what is a "line" in a text file/

So expected-failures files must always end with a newline, to be sure that all lines are processed.
The following check does that:

if [ $(tail -c1 "${EXPECTED_FAILURES_FILE}" | wc -l) -eq 0 ]

tail -c1 gets the last character of a file.

If the last character is not a newline (if it is just an ordinary character) then the count of lines wc -l returns 0.
If gthe last character is a newline, the wc -l returns 1 - a single newline character is a "line".

How Has This Been Tested?

CI and cs3org/reva#2485 - see my comments in the PR.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised: Document use of expected-failures files in acceptance tests docs-server#57
• Changelog item, see TEMPLATE

[individual-it]

doc update needed?

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[phil-davis]

doc update needed?

I couldn't find expected-failures mentioned at all in the developer acceptance test docs. So I raised a general docs issue to document it.

owncloud/docs-server#57