Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] [full-ci] Add end-of-line to expected-failures files #2482

Merged

Conversation

phil-davis
Copy link
Contributor

apiWebdavProperties1/createFileFolderWhenSharesExist.feature:60 is actually passing, but is not always reported as an "unexpected pass" because it is at the very end of the expected-failures files, and there is no newline character at the end.

For now, do not put a scenario reference on the last line. Tomorrow, I will think about making the bash script smarter in core.

Various discussion of this "last line" problem: https://stackoverflow.com/questions/12916352/shell-script-read-missing-last-line

@phil-davis
Copy link
Contributor Author

phil-davis commented Jan 27, 2022

I don't have an explanation for why the original PR #2476 passed where the expected-failures file was last updated, and had no newline at the end of the file. And I don't have an explanation for why CI of the test PR #2479 reports:
apiWebdavProperties1/createFileFolderWhenSharesExist.feature:60 unexpected pass.
for the oCIS storage pipeline, but not for the S3NG storage pipeline. Both expected-failures files had the same missing newline at the end.

@phil-davis
Copy link
Contributor Author

@ishank011 this makes CI pass. createFileFolderWhenSharesExist.feature:60 does always pass, and should never have been in expected-failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants