Fix/epsilon regularization

[michalk8]

• fix how Epsilon was flattened/unflattened
• remove kwargs from Geometry.__init__
• remove scale_epsilon from Geometry.__init__ (must be passed via epsilon_scheduler.Epsilon instance)

closes #308

[marcocuturi]

Thanks a lot Michal for fixing this, this is very welcome and LGTM.

It might be beneficial for all to summarize in a comments section the overall logic of how epsilon is set, and the 4 scenarios we discussed.

[codecov-commenter]

Codecov Report

Merging #310 (baef1d5) into main (ab9d89f) will decrease coverage by 0.12%.
The diff coverage is 77.77%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #310      +/-   ##
==========================================
- Coverage   85.95%   85.84%   -0.12%     
==========================================
  Files          52       52              
  Lines        5590     5594       +4     
  Branches      853      855       +2     
==========================================
- Hits         4805     4802       -3     
- Misses        662      669       +7     
  Partials      123      123              

Impacted Files	Coverage Δ
src/ott/geometry/graph.py	31.87% <0.00%> (ø)
src/ott/problems/linear/potentials.py	62.42% <42.85%> (-1.40%)	⬇️
src/ott/tools/plot.py	19.82% <55.55%> (+<0.01%)	⬆️
src/ott/problems/quadratic/quadratic_problem.py	88.76% <66.66%> (-0.57%)	⬇️
src/ott/geometry/geometry.py	91.08% <91.30%> (-0.09%)	⬇️
src/ott/geometry/epsilon_scheduler.py	94.59% <100.00%> (+5.70%)	⬆️
src/ott/geometry/grid.py	91.60% <100.00%> (-0.07%)	⬇️
src/ott/geometry/low_rank.py	96.37% <100.00%> (-0.03%)	⬇️
src/ott/geometry/pointcloud.py	86.04% <100.00%> (-0.09%)	⬇️

[MUCDK]

Thanks a lot Michal for fixing this, this is very welcome and LGTM.

It might be beneficial for all to summarize in a comments section the overall logic of how epsilon is set, and the 4 scenarios we discussed.

Is there a comment section where I can check this?