Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future broken tests #509

Closed
michalk8 opened this issue Mar 30, 2023 · 1 comment
Closed

Future broken tests #509

michalk8 opened this issue Mar 30, 2023 · 1 comment
Labels
bug Something isn't working test Improve or add new tests

Comments

@michalk8
Copy link
Collaborator

Next release of ott-jax will break our tests, see list below:

FAILED tests/problems/base/test_general_problem.py::TestOTProblem::test_set_xy[kernel] - RecursionError: maximum recursion depth exceeded
FAILED tests/problems/base/test_general_problem.py::TestOTProblem::test_set_x[kernel] - RecursionError: maximum recursion depth exceeded while calling a Python object
FAILED tests/problems/generic/test_gw_problem.py::TestGWProblem::test_pass_arguments[args_to_check1] - AssertionError: assert <ott.geometry.epsilon_scheduler.Epsilon object at 0x292f3ffd0> == 0.7
FAILED tests/problems/base/test_general_problem.py::TestOTProblem::test_set_y[kernel] - RecursionError: maximum recursion depth exceeded while calling a Python object
FAILED tests/problems/generic/test_sinkhorn_problem.py::TestSinkhornProblem::test_pass_arguments[args_to_check0] - assert <ott.geometry.epsilon_scheduler.Epsilon object at 0x286ee36a0> == 0.7
FAILED tests/problems/generic/test_sinkhorn_problem.py::TestSinkhornProblem::test_pass_arguments[args_to_check1] - assert <ott.geometry.epsilon_scheduler.Epsilon object at 0x287afa4d0> == 0.8
FAILED tests/problems/generic/test_fgw_problem.py::TestFGWProblem::test_pass_arguments[args_to_check0] - AssertionError: assert <ott.geometry.epsilon_scheduler.Epsilon object at 0x2920ed210> == 0.5
FAILED tests/problems/space/test_alignment_problem.py::TestAlignmentProblem::test_pass_arguments[args_to_check1] - AssertionError: assert <ott.geometry.epsilon_scheduler.Epsilon object at 0x2989dd2a0> == 0.7
FAILED tests/problems/generic/test_fgw_problem.py::TestFGWProblem::test_pass_arguments[args_to_check1] - AssertionError: assert <ott.geometry.epsilon_scheduler.Epsilon object at 0x28f1fbee0> == 0.7
FAILED tests/problems/generic/test_gw_problem.py::TestGWProblem::test_pass_arguments[args_to_check0] - AssertionError: assert <ott.geometry.epsilon_scheduler.Epsilon object at 0x2a35eb5e0> == 0.5
FAILED tests/problems/space/test_alignment_problem.py::TestAlignmentProblem::test_pass_arguments[args_to_check0] - AssertionError: assert <ott.geometry.epsilon_scheduler.Epsilon object at 0x29de53220> == 0.5
FAILED tests/problems/space/test_mixins.py::TestSpatialMappingAnalysisMixin::test_regression_testing - AttributeError: 'ArrayImpl' object has no attribute 'tree_flatten'
FAILED tests/problems/space/test_mapping_problem.py::TestMappingProblem::test_pass_arguments[args_to_check0] - AssertionError: assert <ott.geometry.epsilon_scheduler.Epsilon object at 0x28f40c0a0> == 0.5
FAILED tests/problems/space/test_mapping_problem.py::TestMappingProblem::test_pass_arguments[args_to_check1] - AssertionError: assert <ott.geometry.epsilon_scheduler.Epsilon object at 0x291262140> == 0.7
FAILED tests/problems/space/test_mixins.py::TestSpatialAlignmentAnalysisMixin::test_regression_testing - AttributeError: 'ArrayImpl' object has no attribute 'tree_flatten'
FAILED tests/problems/spatio_temporal/test_spatio_temporal_problem.py::TestSpatioTemporalProblem::test_pass_arguments[args_to_check0] - AssertionError: assert <ott.geometry.epsilon_scheduler.Epsilon object at 0x2b561fbe0> == 0.5
FAILED tests/problems/spatio_temporal/test_spatio_temporal_problem.py::TestSpatioTemporalProblem::test_pass_arguments[args_to_check1] - AssertionError: assert <ott.geometry.epsilon_scheduler.Epsilon object at 0x2b6f78d00> == 0.7
FAILED tests/problems/time/test_temporal_problem.py::TestTemporalProblem::test_pass_arguments[args_to_check1] - assert <ott.geometry.epsilon_scheduler.Epsilon object at 0x28f518dc0> == 0.8
FAILED tests/problems/time/test_lineage_problem.py::TestLineageProblem::test_pass_arguments[args_to_check0] - AssertionError: assert <ott.geometry.epsilon_scheduler.Epsilon object at 0x286ebd390> == 0.5
FAILED tests/problems/time/test_temporal_problem.py::TestTemporalProblem::test_pass_arguments[args_to_check0] - assert <ott.geometry.epsilon_scheduler.Epsilon object at 0x2989c88b0> == 0.7
FAILED tests/problems/time/test_lineage_problem.py::TestLineageProblem::test_pass_arguments[args_to_check1] - AssertionError: assert <ott.geometry.epsilon_scheduler.Epsilon object at 0x2a3fe1180> == 0.7

Some will be fixed by ott-jax/ott#349, but most are on our side (related to epsilon; ott-jax/ott#310)
We should also consider adding a CI job for the latest ott-jax in the future.

@michalk8 michalk8 added test Improve or add new tests bug (not-urgent) Something isn't working; is not urgent to fix labels Mar 30, 2023
@michalk8 michalk8 added bug Something isn't working and removed bug (not-urgent) Something isn't working; is not urgent to fix labels Jun 20, 2023
@giovp
Copy link
Member

giovp commented Jun 29, 2023

We should also consider adding a CI job for the latest ott-jax in the future.

this is a great suggestion yes, could be done more generally for stuff like pandas and jax, we discussed this internally in scverse also for the template packages.

@MUCDK MUCDK closed this as completed Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test Improve or add new tests
Projects
None yet
Development

No branches or pull requests

3 participants