Correct package requirements for tests. #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e running on github.
marcocuturi
reviewed
Feb 14, 2023
| @@ -177,6 +174,7 @@ legacy_tox_ini = """ | |||
| [testenv] | |||
| extras = test | |||
| pass_env = CUDA_*,PYTEST_*,CI | |||
| deps = py{38,39,310}: scikit-sparse>=0.4.6 | |||
There was a problem hiding this comment.
this is for graph geometry, right?
|
LGTM, thanks! |
pierreablin
pushed a commit
to pierreablin/ott
that referenced
this pull request
Feb 14, 2023
* Test commit on personal fork. * Test commit on personal fork. * Add and update copyrights. * Correct packages requirements for tests. * Add apt-get install libsuitesparse-dev to get tests with scikit-sparse running on github. * Corect os runner check and also add it to "norma" tests. * Add brew install for scikit sparse. * remove scikit-sparse from 3.11. * Install libsuite sparse for gpu env tests. * Remove libsuite sparse for gpu env tests (added in the docker). --------- Co-authored-by: antoinewehenkel <awehenkel@apple.com>
michalk8
pushed a commit
that referenced
this pull request
Jun 27, 2024
* Test commit on personal fork. * Test commit on personal fork. * Add and update copyrights. * Correct packages requirements for tests. * Add apt-get install libsuitesparse-dev to get tests with scikit-sparse running on github. * Corect os runner check and also add it to "norma" tests. * Add brew install for scikit sparse. * remove scikit-sparse from 3.11. * Install libsuite sparse for gpu env tests. * Remove libsuite sparse for gpu env tests (added in the docker). --------- Co-authored-by: antoinewehenkel <awehenkel@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add scikit-sparse in the package requirements.