Skip to content

Commit

Permalink
Correct package requirements for tests. (#271)
Browse files Browse the repository at this point in the history
* Test commit on personal fork.

* Test commit on personal fork.

* Add and update copyrights.

* Correct packages requirements for tests.

* Add apt-get install libsuitesparse-dev to get tests with scikit-sparse running on github.

* Corect os runner check  and also add it to "norma" tests.

* Add brew install for scikit sparse.

* remove scikit-sparse from 3.11.

* Install libsuite sparse for gpu env tests.

* Remove libsuite sparse for gpu env tests (added in the docker).

---------

Co-authored-by: antoinewehenkel <awehenkel@apple.com>
  • Loading branch information
AWehenkel and AWehenkel authored Feb 14, 2023
1 parent 9a2ac29 commit ccffbdd
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 3 deletions.
21 changes: 21 additions & 0 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,16 @@ jobs:
with:
python-version: '3.9'

- name: Install apt dependencies
if: ${{ runner.os == 'Linux' }}
run: |
sudo apt-get install libsuitesparse-dev
- name: Install brew dependencies
if: ${{ runner.os == 'macOS' }}
run: |
brew install suite-sparse
- name: Install dependencies
run: |
python -m pip install --upgrade pip
Expand All @@ -44,6 +54,7 @@ jobs:
options: --gpus="device=12"
steps:
- uses: actions/checkout@v3

- name: Install dependencies
# `jax[cuda]<0.4` because of Docker issues: https://github.com/google/jax/issues/13758
# `flax<0.6.5` because it requires `jax>=0.4.2`
Expand Down Expand Up @@ -80,6 +91,16 @@ jobs:
with:
python-version: ${{ matrix.python-version }}

- name: Install apt dependencies
if: ${{ runner.os == 'Linux' }}
run: |
sudo apt-get install libsuitesparse-dev
- name: Install brew dependencies
if: ${{ runner.os == 'macOS' }}
run: |
brew install suite-sparse
- name: Install dependencies
run: |
python -m pip install --upgrade pip
Expand Down
4 changes: 1 addition & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,6 @@ test = [
"networkx>=2.5",
"scikit-learn>=1.0"
]
experimental = [
"scikit-sparse>=0.4.6",
]
docs = [
"sphinx>=4.0",
"ipython>=7.20.0",
Expand Down Expand Up @@ -177,6 +174,7 @@ legacy_tox_ini = """
[testenv]
extras = test
pass_env = CUDA_*,PYTEST_*,CI
deps = py{38,39,310}: scikit-sparse>=0.4.6
commands =
gpu: pip install "jax[cuda]" -f https://storage.googleapis.com/jax-releases/jax_cuda_releases.html
python -m pytest {tty:--color=yes} {posargs: \
Expand Down

0 comments on commit ccffbdd

Please sign in to comment.