Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: swagger specs for settings api's browser flow #825

Merged
merged 2 commits into from
Nov 15, 2020

Conversation

davidcheung
Copy link
Contributor

@davidcheung davidcheung commented Nov 13, 2020

Related issue

Closes ory/sdk#43

Proposed changes

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further comments

@zepatrik
Copy link
Member

The swagger schema is generated from code comments, you will have to update it here https://github.com/ory/kratos/blob/master/selfservice/flow/settings/handler.go#L152 and then run make sdk. Or let the CI do the work 😉

@zepatrik
Copy link
Member

So the CI did regenerate the SDK but could not push the commit. Is this intended behavior for forks @aeneasr ? It will be generated on master anyway so I will merge this now.

@zepatrik zepatrik merged commit 28d50f4 into ory:master Nov 15, 2020
@aeneasr
Copy link
Member

aeneasr commented Nov 16, 2020

@zepatrik I guess the push should go to the fork but I think we have currently configured it to push to the upstream. I can look into this if I have some time.

@zepatrik
Copy link
Member

Yes, that's the current behavior. It is fine like this IMO as well because the SDK will be regenerated on master anyway. Tracked it as ory/ci#44

@davidcheung davidcheung deleted the fix-settings-browser-flow-specs branch November 16, 2020 17:06
@aeneasr aeneasr added the corp/m4 Up for M4 at Ory Corp. label Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
corp/m4 Up for M4 at Ory Corp.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kratos: route mismatch for specs v0.5.3-alpha.1
3 participants