Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kratos: route mismatch for specs v0.5.3-alpha.1 #43

Closed
davidcheung opened this issue Nov 10, 2020 · 3 comments · Fixed by ory/kratos#825
Closed

kratos: route mismatch for specs v0.5.3-alpha.1 #43

davidcheung opened this issue Nov 10, 2020 · 3 comments · Fixed by ory/kratos#825

Comments

@davidcheung
Copy link

https://github.com/ory/sdk/blob/master/spec/kratos/v0.5.3-alpha.1.pre.0.json#L1132

I believe this should be /self-service/settings/browser instead of /self-service/settings/browser/flow since 0.5.0+
this leads to a 404 when using the sdk to fetch the settings form

I'm not sure what the workflow for generating the SDKs so didn't make a PR

@tacurran
Copy link
Member

@davidcheung please take a look at the SDK creation setup here https://github.com/ory/kratos/blob/master/.circleci/config.yml

Perhaps you can explain the error in a PR ? I can also help you with the problem resolution then

@davidcheung
Copy link
Author

@tacurran the error is the specs have the wrong url, it shouldn't have /flow at the end since 0.5.0

  1. The docs have it without /flow trailing https://www.ory.sh/kratos/docs/self-service/flows/user-settings#profile-updates-for-browser-clients
  2. settings's api flow has it without /flow trailing https://github.com/ory/sdk/blob/master/spec/kratos/v0.5.3-alpha.1.pre.0.json#L1093
  3. registration has it without /flow trailing https://github.com/ory/sdk/blob/master/spec/kratos/v0.5.3-alpha.1.pre.0.json#L950
  4. login has it without /flow trailing https://github.com/ory/sdk/blob/master/spec/kratos/v0.5.3-alpha.1.pre.0.json#L601

@davidcheung
Copy link
Author

davidcheung commented Nov 13, 2020

Please note that the code on kratos side is fine, its just the SDK has the wrong specs on the path so if you use initializeSelfServiceSettingsViaBrowserFlow you will get a 404, but if you dont use the SDK and hit http://127.0.0.1:4433/self-service/settings/browser(without /flow) it will be fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants